Add similar behavior for all Assign nodes (#4996)

Co-authored-by: phpstan-bot <79867460+phpstan-bot@users.noreply.github.com>
Co-authored-by: phpstan-bot <ondrej+phpstanbot@mirtes.cz>

Author: VincentLanglet

src/Parser/NewAssignedToPropertyVisitor.php

@@ -16,7 +16,7 @@ final class NewAssignedToPropertyVisitor extends NodeVisitorAbstract
 	#[Override]
 	public function enterNode(Node $node): ?Node
 	{
-		if ($node instanceof Node\Expr\Assign || $node instanceof Node\Expr\AssignRef) {
+		if ($node instanceof Node\Expr\Assign || $node instanceof Node\Expr\AssignRef || $node instanceof Node\Expr\AssignOp) {
 			if (
 				($node->var instanceof Node\Expr\PropertyFetch || $node->var instanceof Node\Expr\StaticPropertyFetch)
 				&& $node->expr instanceof Node\Expr\New_

src/Rules/PhpDoc/InvalidPHPStanDocTagRule.php

@@ -88,7 +88,11 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 		if ($node instanceof Node\Stmt\Expression) {
-			if (!$node->expr instanceof Node\Expr\Assign && !$node->expr instanceof Node\Expr\AssignRef) {
+			if (
+				!$node->expr instanceof Node\Expr\Assign
+				&& !$node->expr instanceof Node\Expr\AssignRef
+				&& !$node->expr instanceof Node\Expr\AssignOp
+			) {
 				return [];
 			}
 		}

src/Rules/PhpDoc/InvalidPhpDocTagValueRule.php

@@ -47,7 +47,11 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 		if ($node instanceof Node\Stmt\Expression) {
-			if (!$node->expr instanceof Node\Expr\Assign && !$node->expr instanceof Node\Expr\AssignRef) {
+			if (
+				!$node->expr instanceof Node\Expr\Assign
+				&& !$node->expr instanceof Node\Expr\AssignRef
+				&& !$node->expr instanceof Node\Expr\AssignOp
+			) {
 				return [];
 			}
 		}

src/Rules/PhpDoc/WrongVariableNameInVarTagRule.php

@@ -288,7 +288,11 @@ private function processForeach(Scope $scope, Node\Expr $iterateeExpr, ?Node\Exp
 	 */
 	private function processExpression(Scope $scope, Expr $expr, array $varTags): array
 	{
-		if ($expr instanceof Node\Expr\Assign || $expr instanceof Node\Expr\AssignRef) {
+		if (
+			$expr instanceof Node\Expr\Assign
+			|| $expr instanceof Node\Expr\AssignRef
+			|| $expr instanceof Node\Expr\AssignOp
+		) {
 			return $this->processAssign($scope, $expr->var, $expr->expr, $varTags);
 		}
 

tests/PHPStan/Rules/PhpDoc/InvalidPHPStanDocTagRuleTest.php

@@ -54,6 +54,16 @@ public function testBug8697(): void
 		$this->analyse([__DIR__ . '/data/bug-8697.php'], []);
 	}
 
+	public function testAssignOperator(): void
+	{
+		$this->analyse([__DIR__ . '/data/invalid-phpstan-doc-assign-operator.php'], [
+			[
+				'Unknown PHPDoc tag: @phpstan-va',
+				9,
+			],
+		]);
+	}
+
 	#[RequiresPhp('>= 8.4')]
 	public function testPropertyHooks(): void
 	{

tests/PHPStan/Rules/PhpDoc/InvalidPhpDocTagValueRuleTest.php

@@ -126,6 +126,16 @@ public function testIgnoreWithinPhpDoc(): void
 		$this->analyse([__DIR__ . '/data/ignore-line-within-phpdoc.php'], []);
 	}
 
+	public function testAssignOperator(): void
+	{
+		$this->analyse([__DIR__ . '/data/invalid-phpdoc-assign-operator.php'], [
+			[
+				'PHPDoc tag @var has invalid value (\\\\Foo|\Bar $test): Unexpected token "\\\\\\\\Foo|\\\\Bar", expected type at offset 9 on line 1',
+				8,
+			],
+		]);
+	}
+
 	public function testBug6299(): void
 	{
 		$this->analyse([__DIR__ . '/data/bug-6299.php'], [

tests/PHPStan/Rules/PhpDoc/WrongVariableNameInVarTagRuleTest.php

@@ -548,6 +548,28 @@ public function testReportWrongType(
 		$this->analyse([__DIR__ . '/data/wrong-var-native-type.php'], $expectedErrors);
 	}
 
+	public function testAssignOperator(): void
+	{
+		$this->analyse([__DIR__ . '/data/wrong-variable-name-var-assign-op.php'], [
+			[
+				'PHPDoc tag @var with type int is not subtype of native type void.',
+				11,
+			],
+			[
+				'PHPDoc tag @var with type int is not subtype of native type void.',
+				14,
+			],
+			[
+				'PHPDoc tag @var with type int is not subtype of native type void.',
+				20,
+			],
+			[
+				'PHPDoc tag @var with type int is not subtype of native type void.',
+				23,
+			],
+		]);
+	}
+
 	public function testBug12457(): void
 	{
 		$this->checkTypeAgainstPhpDocType = true;

tests/PHPStan/Rules/PhpDoc/data/invalid-phpdoc-assign-operator.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace InvalidPhpDocAssignOperator;
+
+function foo()
+{
+
+	/** @var \\Foo|\Bar $test */
+	$test ??= doFoo();
+
+}

tests/PHPStan/Rules/PhpDoc/data/invalid-phpstan-doc-assign-operator.php

@@ -0,0 +1,12 @@
+<?php
+
+namespace InvalidPHPStanDocAssignOperator;
+
+class Boo extends Baz
+{
+	function baz()
+	{
+		/** @phpstan-va */
+		$c ??= 'foo';
+	}
+}

tests/PHPStan/Rules/PhpDoc/data/wrong-variable-name-var-assign-op.php

@@ -0,0 +1,31 @@
+<?php
+
+namespace WrongVariableNameVarTagAssignOperator;
+
+class Foo
+{
+
+	public function doFoo()
+	{
+		/** @var int $test */
+		$test ??= doFoo();
+
+		/** @var int */
+		$test ??= doFoo();
+	}
+
+	public function doBar(string $string)
+	{
+		/** @var int $string */
+		$string .= doFoo();
+
+		/** @var int */
+		$string .= doFoo();
+	}
+
+}
+
+function doFoo(): void
+{
+
+}