Skip to content

Commit 749aafe

Browse files
VincentLangletVincentLanglet
committed
Fix cast object inferences
1 parent 81ecd5d commit 749aafe

File tree

6 files changed

+117
-7
lines changed

6 files changed

+117
-7
lines changed

‎resources/functionMap.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1650,7 +1650,7 @@
16501650
'DomXsltStylesheet::result_dump_mem' => ['string', 'xmldoc'=>'DOMDocument'],
16511651
'DOTNET::__construct' => ['void', 'assembly_name'=>'string', 'class_name'=>'string', 'codepage='=>'int'],
16521652
'dotnet_load' => ['int', 'assembly_name'=>'string', 'datatype_name='=>'string', 'codepage='=>'int'],
1653-
'doubleval' => ['float', 'var'=>'int|float|__stringNotStringable|bool|array|resource|null'],
1653+
'doubleval' => ['float', 'var'=>'int|float|__stringNotStringable|bool|array|resource|GMP|SimpleXMLElement|null'],
16541654
'Ds\Deque::__construct' => ['void', 'values='=>'mixed'],
16551655
'Ds\Deque::count' => ['0|positive-int'],
16561656
'Ds\Deque::jsonSerialize' => ['array'],
@@ -2448,7 +2448,7 @@
24482448
'finfo_file' => ['string|false', 'finfo'=>'resource', 'file_name'=>'string', 'options='=>'int', 'context='=>'resource'],
24492449
'finfo_open' => ['resource|false', 'options='=>'int', 'arg='=>'string'],
24502450
'finfo_set_flags' => ['bool', 'finfo'=>'resource', 'options'=>'int'],
2451-
'floatval' => ['float', 'var'=>'int|float|__stringNotStringable|bool|array|resource|null'],
2451+
'floatval' => ['float', 'var'=>'int|float|__stringNotStringable|bool|array|resource|GMP|SimpleXMLElement|null'],
24522452
'flock' => ['bool', 'fp'=>'resource', 'operation'=>'int-mask<LOCK_SH, LOCK_EX, LOCK_UN, LOCK_NB>', '&w_wouldblock='=>'0|1'],
24532453
'floor' => ['__benevolent<float|false>', 'number'=>'float'],
24542454
'flush' => ['void'],
@@ -5075,7 +5075,7 @@
50755075
'intltz_to_date_time_zone' => ['DateTimeZone|false', 'obj'=>''],
50765076
'intltz_use_daylight_time' => ['bool', 'obj'=>''],
50775077
'intlz_create_default' => ['IntlTimeZone'],
5078-
'intval' => ['int', 'var'=>'int|float|__stringNotStringable|bool|array|resource|null', 'base='=>'int'],
5078+
'intval' => ['int', 'var'=>'int|float|__stringNotStringable|bool|array|resource|GMP|SimpleXMLElement|null', 'base='=>'int'],
50795079
'InvalidArgumentException::__clone' => ['void'],
50805080
'InvalidArgumentException::__construct' => ['void', 'message='=>'string', 'code='=>'int', 'previous='=>'(?Throwable)|(?InvalidArgumentException)'],
50815081
'InvalidArgumentException::__toString' => ['string'],
@@ -10438,7 +10438,7 @@
1043810438
'strtoupper' => ['uppercase-string', 'str'=>'string'],
1043910439
'strtr' => ['string', 'str'=>'string', 'from'=>'string', 'to'=>'string'],
1044010440
'strtr\'1' => ['string', 'str'=>'string', 'replace_pairs'=>'array'],
10441-
'strval' => ['string', 'var'=>'__stringAndStringable|int|float|bool|resource|null'],
10441+
'strval' => ['string', 'var'=>'__stringAndStringable|int|float|bool|resource|GMP|null'],
1044210442
'substr' => ['__benevolent<string|false>', 'string'=>'string', 'start'=>'int', 'length='=>'int'],
1044310443
'substr_compare' => ['int<-1, 1>|false', 'main_str'=>'string', 'str'=>'string', 'offset'=>'int', 'length='=>'int', 'case_sensitivity='=>'bool'],
1044410444
'substr_count' => ['0|positive-int', 'haystack'=>'string', 'needle'=>'string', 'offset='=>'int', 'length='=>'int'],

‎src/Type/ObjectType.php‎

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -772,7 +772,10 @@ public function toAbsoluteNumber(): Type
772772

773773
public function toInteger(): Type
774774
{
775-
if ($this->isInstanceOf('SimpleXMLElement')->yes()) {
775+
if (
776+
$this->isInstanceOf('SimpleXMLElement')->yes()
777+
|| $this->isInstanceOf('GMP')->yes()
778+
) {
776779
return new IntegerType();
777780
}
778781

@@ -785,15 +788,21 @@ public function toInteger(): Type
785788

786789
public function toFloat(): Type
787790
{
788-
if ($this->isInstanceOf('SimpleXMLElement')->yes()) {
791+
if (
792+
$this->isInstanceOf('SimpleXMLElement')->yes()
793+
|| $this->isInstanceOf('GMP')->yes()
794+
) {
789795
return new FloatType();
790796
}
791797
return new ErrorType();
792798
}
793799

794800
public function toString(): Type
795801
{
796-
if ($this->isInstanceOf('BcMath\Number')->yes()) {
802+
if (
803+
$this->isInstanceOf('BcMath\Number')->yes()
804+
|| $this->isInstanceOf('GMP')->yes()
805+
) {
797806
return new IntersectionType([
798807
new StringType(),
799808
new AccessoryNumericStringType(),
@@ -910,6 +919,7 @@ public function toBoolean(): BooleanType
910919
if (
911920
$this->isInstanceOf('SimpleXMLElement')->yes()
912921
|| $this->isInstanceOf('BcMath\Number')->yes()
922+
|| $this->isInstanceOf('GMP')->yes()
913923
) {
914924
return new BooleanType();
915925
}

‎tests/PHPStan/Rules/Cast/InvalidCastRuleTest.php‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,20 @@ public function testRuleWithNullsafeVariant(): void
7272
]);
7373
}
7474

75+
public function testBug14136(): void
76+
{
77+
$this->analyse([__DIR__ . '/data/bug-14136.php'], [
78+
[
79+
'Cannot cast BcMath\Number to int.',
80+
15,
81+
],
82+
[
83+
'Cannot cast BcMath\Number to float.',
84+
22,
85+
],
86+
]);
87+
}
88+
7589
public function testCastObjectToString(): void
7690
{
7791
$this->analyse([__DIR__ . '/data/cast-object-to-string.php'], [

‎tests/PHPStan/Rules/Cast/data/bug-14136.php‎

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
<?php declare(strict_types = 1);
2+
3+
namespace Bug14136Cast;
4+
5+
$xml = <<<'EOT'
6+
<?xml version="1.0"?><item>3</item>
7+
EOT;
8+
9+
$xml = simplexml_load_string($xml);
10+
var_dump(intval($xml));
11+
var_dump(intval(gmp_init(42)));
12+
var_dump(intval (new \BCMath\Number(99))); // Invalid
13+
var_dump((int) ($xml));
14+
var_dump((int)(gmp_init(42)));
15+
var_dump((int) new \BCMath\Number(99)); // Invalid
16+
17+
var_dump(floatval ($xml));
18+
var_dump(floatval(gmp_init(42)));
19+
var_dump(floatval(new \BCMath\Number(99))); // Invalid
20+
var_dump((float) ($xml));
21+
var_dump((float)(gmp_init(42)));
22+
var_dump((float) new \BCMath\Number(99)); // Invalid
23+
24+
var_dump(strval($xml));
25+
var_dump(strval(gmp_init(42)));
26+
var_dump(strval(new \BCMath\Number(99)));
27+
var_dump((string) ($xml));
28+
var_dump((string)(gmp_init(42)));
29+
var_dump((string) new \BCMath\Number(99));
30+
31+
var_dump(boolval($xml));
32+
var_dump(boolval(gmp_init(42)));
33+
var_dump(boolval (new \BCMath\Number(99)));
34+
var_dump((bool) ($xml));
35+
var_dump((bool) (gmp_init(42)));
36+
var_dump((bool) (new \BCMath\Number(42)));

‎tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2678,6 +2678,20 @@ public function testBug9652(): void
26782678
$this->analyse([__DIR__ . '/data/bug-9652.php'], []);
26792679
}
26802680

2681+
public function testBug14136(): void
2682+
{
2683+
$this->analyse([__DIR__ . '/data/bug-14136.php'], [
2684+
[
2685+
'Parameter #1 $value of function intval expects array|bool|float|GMP|int|resource|SimpleXMLElement|string|null, BcMath\Number given.',
2686+
12,
2687+
],
2688+
[
2689+
'Parameter #1 $value of function floatval expects array|bool|float|GMP|int|resource|SimpleXMLElement|string|null, BcMath\Number given.',
2690+
19,
2691+
],
2692+
]);
2693+
}
2694+
26812695
#[RequiresPhp('>= 8.1')]
26822696
public function testBug8936(): void
26832697
{

‎tests/PHPStan/Rules/Functions/data/bug-14136.php‎

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
<?php declare(strict_types = 1);
2+
3+
namespace Bug14136;
4+
5+
$xml = <<<'EOT'
6+
<?xml version="1.0"?><item>3</item>
7+
EOT;
8+
9+
$xml = simplexml_load_string($xml);
10+
var_dump(intval($xml));
11+
var_dump(intval(gmp_init(42)));
12+
var_dump(intval (new \BCMath\Number(99))); // Invalid
13+
var_dump((int) ($xml));
14+
var_dump((int)(gmp_init(42)));
15+
var_dump((int) new \BCMath\Number(99)); // Invalid
16+
17+
var_dump(floatval ($xml));
18+
var_dump(floatval(gmp_init(42)));
19+
var_dump(floatval(new \BCMath\Number(99))); // Invalid
20+
var_dump((float) ($xml));
21+
var_dump((float)(gmp_init(42)));
22+
var_dump((float) new \BCMath\Number(99)); // Invalid
23+
24+
var_dump(strval($xml));
25+
var_dump(strval(gmp_init(42)));
26+
var_dump(strval(new \BCMath\Number(99)));
27+
var_dump((string) ($xml));
28+
var_dump((string)(gmp_init(42)));
29+
var_dump((string) new \BCMath\Number(99));
30+
31+
var_dump(boolval($xml));
32+
var_dump(boolval(gmp_init(42)));
33+
var_dump(boolval (new \BCMath\Number(99)));
34+
var_dump((bool) ($xml));
35+
var_dump((bool) (gmp_init(42)));
36+
var_dump((bool) (new \BCMath\Number(42)));

0 commit comments

Comments
 (0)