fixes

Author: ondrejmirtes

src/Command/BisectCommand.php

@@ -143,9 +143,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 			return 1;
 		}
 
-		$commits = array_values(array_filter($commits, static function (array $commit) use ($checksumShas): bool {
-			return isset($checksumShas[$commit['sha']]);
-		}));
+		$commits = array_values(array_filter($commits, static fn (array $commit): bool => isset($checksumShas[$commit['sha']])));
 
 		if (count($commits) === 0) {
 			$io->error('No commits found that change phpstan.phar between the specified releases.');
@@ -318,12 +316,12 @@ private function getPharChecksumCommitShas(Client $client, string $bad, array $r
 
 			$foundOutOfRange = false;
 			foreach ($commits as $commit) {
-				if (isset($rangeShas[$commit['sha']])) {
-					$checksumShas[$commit['sha']] = true;
-				} else {
+				if (!isset($rangeShas[$commit['sha']])) {
 					$foundOutOfRange = true;
 					break;
 				}
+
+				$checksumShas[$commit['sha']] = true;
 			}
 
 			if ($foundOutOfRange || count($commits) < $perPage) {

tests/PHPStan/Command/Bisect/BinarySearchTest.php

@@ -9,6 +9,7 @@
 use function array_search;
 use function count;
 use function range;
+use function sprintf;
 
 class BinarySearchTest extends TestCase
 {
@@ -141,7 +142,7 @@ public static function dataFullBisect(): iterable
 
 		foreach ($lists as $name => $items) {
 			foreach ($items as $badItem) {
-				yield "$name, first bad is $badItem" => [$items, $badItem];
+				yield sprintf('%s, first bad is %s', $name, $badItem) => [$items, $badItem];
 			}
 		}
 	}