Fix incorrect type-narrowing with polluteScopeWithAlwaysIterableForeach

- Fixed processAlwaysIterableForeachScopeWithoutPollute using stale
  conditional expressions from before the foreach body, which caused
  variable aliases (e.g. $current = $initial) to persist even after
  reassignment inside the foreach
- Changed to use $finalScope->conditionalExpressions which properly
  reflects invalidated aliases from foreach body assignments
- New regression test in tests/PHPStan/Analyser/data/bug-14446.php

Closes phpstan/phpstan#14446

Author: VincentLanglet

src/Analyser/MutatingScope.php

@@ -3877,7 +3877,7 @@ public function processAlwaysIterableForeachScopeWithoutPollute(self $finalScope
 			$this->getNamespace(),
 			$expressionTypes,
 			$nativeTypes,
-			$this->conditionalExpressions,
+			$finalScope->conditionalExpressions,
 			$this->inClosureBindScopeClasses,
 			$this->anonymousFunctionReflection,
 			$this->inFirstLevelStatement,

tests/PHPStan/Analyser/Bug14446Test.php

@@ -0,0 +1,36 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Analyser;
+
+use PHPStan\Testing\TypeInferenceTestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
+
+class Bug14446Test extends TypeInferenceTestCase
+{
+
+	public static function dataFileAsserts(): iterable
+	{
+		yield from self::gatherAssertTypes(__DIR__ . '/data/bug-14446.php');
+	}
+
+	/**
+	 * @param mixed ...$args
+	 */
+	#[DataProvider('dataFileAsserts')]
+	public function testFileAsserts(
+		string $assertType,
+		string $file,
+		...$args,
+	): void
+	{
+		$this->assertFileAsserts($assertType, $file, ...$args);
+	}
+
+	public static function getAdditionalConfigFiles(): array
+	{
+		return [
+			__DIR__ . '/bug-14446.neon',
+		];
+	}
+
+}

tests/PHPStan/Analyser/bug-14446.neon

@@ -0,0 +1,2 @@
+parameters:
+	polluteScopeWithAlwaysIterableForeach: false

tests/PHPStan/Analyser/data/bug-14446.php

@@ -0,0 +1,24 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14446;
+
+use function PHPStan\Testing\assertType;
+
+function test(bool $initial): void {
+    $current = $initial;
+
+    while (true) {
+		assertType('bool', $initial);
+        if (!$current) {
+			assertType('bool', $initial);
+            break;
+        }
+
+        $items = [1];
+        foreach ($items as $item) {
+            $current = false;
+        }
+    }
+
+	assertType('bool', $initial);
+}