Add non-regression tests for #13591, #12597, and #10422

- #13591: nsrt + rule test verifying conditional parameter type narrowing
  works with boolean-and guard (no false positive for int|null parameter)
- #12597: rule test verifying variable definedness after in_array check
  (no false "Variable might not be defined" warning)
- #10422: nsrt + rule test verifying method call on nullable after
  if/elseif guard with die() (no false "Cannot call method on null")

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: phpstan-bot

tests/PHPStan/Analyser/nsrt/bug-10422.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types = 1);
+
+namespace Bug10422;
+
+use function PHPStan\Testing\assertType;
+
+class TestClass {
+	public function test(): void {}
+	public function something(): bool { return true; }
+}
+
+function test(?TestClass $test): void
+{
+	$error = '';
+
+	if (!$test) {
+		$error = 'missing test';
+	} else if ($test->something()) {
+		$error = 'another';
+	}
+	if ($error) {
+		die('Done');
+	}
+	assertType('Bug10422\TestClass', $test);
+	$test->test();
+}

tests/PHPStan/Analyser/nsrt/bug-13591.php

@@ -0,0 +1,24 @@
+<?php
+
+declare(strict_types = 1);
+
+namespace Bug13591;
+
+use function PHPStan\Testing\assertType;
+
+function processHotel(int $hotelId): void {}
+
+/**
+ * @param 'get_rooms'|'get_hotels' $action
+ */
+function test(string $action, ?int $hotelId): void
+{
+	if ($action === 'get_rooms' && $hotelId === null) {
+		throw new \InvalidArgumentException('Hotel ID is required');
+	}
+
+	if ($action === 'get_rooms') {
+		assertType('int', $hotelId);
+		processHotel($hotelId);
+	}
+}

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

@@ -2828,4 +2828,9 @@ public function testBug4608(): void
 		]);
 	}
 
+	public function testBug13591(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-13591.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Functions/data/bug-13591.php

@@ -0,0 +1,21 @@
+<?php
+
+declare(strict_types = 1);
+
+namespace Bug13591Rule;
+
+function processHotel(int $hotelId): void {}
+
+/**
+ * @param 'get_rooms'|'get_hotels' $action
+ */
+function test(string $action, ?int $hotelId): void
+{
+	if ($action === 'get_rooms' && $hotelId === null) {
+		throw new \InvalidArgumentException('Hotel ID is required');
+	}
+
+	if ($action === 'get_rooms') {
+		processHotel($hotelId);
+	}
+}

tests/PHPStan/Rules/Methods/CallMethodsRuleTest.php

@@ -4001,4 +4001,12 @@ public function testBug11978(): void
 		]);
 	}
 
+	public function testBug10422(): void
+	{
+		$this->checkThisOnly = false;
+		$this->checkNullables = true;
+		$this->checkUnionTypes = true;
+		$this->analyse([__DIR__ . '/data/bug-10422.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Methods/data/bug-10422.php

@@ -0,0 +1,25 @@
+<?php
+
+declare(strict_types = 1);
+
+namespace Bug10422Rule;
+
+class TestClass {
+	public function test(): void {}
+	public function something(): bool { return true; }
+}
+
+function test(?TestClass $test): void
+{
+	$error = '';
+
+	if (!$test) {
+		$error = 'missing test';
+	} else if ($test->something()) {
+		$error = 'another';
+	}
+	if ($error) {
+		die('Done');
+	}
+	$test->test();
+}

tests/PHPStan/Rules/Variables/DefinedVariableRuleTest.php

@@ -1499,4 +1499,13 @@ public function testBug14117(): void
 		]);
 	}
 
+	public function testBug12597(): void
+	{
+		$this->cliArgumentsVariablesRegistered = true;
+		$this->polluteScopeWithLoopInitialAssignments = false;
+		$this->checkMaybeUndefinedVariables = true;
+		$this->polluteScopeWithAlwaysIterableForeach = true;
+		$this->analyse([__DIR__ . '/data/bug-12597.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Variables/data/bug-12597.php

@@ -0,0 +1,24 @@
+<?php
+
+declare(strict_types = 1);
+
+namespace Bug12597;
+
+class HelloWorld
+{
+	private const TYPE_1 = 1;
+	private const TYPE_2 = 2;
+
+	public function test(int $type): void
+	{
+		if (in_array($type, [self::TYPE_1, self::TYPE_2], true)) {
+			$message = 'Hello!';
+		}
+
+		if ($type === self::TYPE_1) {
+			$this->message($message);
+		}
+	}
+
+	public function message(string $message): void {}
+}