Update PDOStatement stub (#5132)

Co-authored-by: phpstan-bot <79867460+phpstan-bot@users.noreply.github.com>

Author: VincentLanglet

stubs/PDOStatement.stub

@@ -1,8 +1,8 @@
 <?php
 
 /**
- * @implements Traversable<array<int|string, mixed>>
- * @implements IteratorAggregate<array<int|string, mixed>>
+ * @implements Traversable<mixed>
+ * @implements IteratorAggregate<mixed>
  * @link https://php.net/manual/en/class.pdostatement.php
  */
 class PDOStatement implements Traversable, IteratorAggregate
@@ -21,7 +21,7 @@ class PDOStatement implements Traversable, IteratorAggregate
     public function getColumnMeta(int $column) {}
 
     /**
-     * @return Iterator<mixed, array<int|string, mixed>>
+     * @return Iterator<mixed, mixed>
      */
     public function getIterator() {}
 }

tests/PHPStan/Analyser/nsrt/bug-8886.php

@@ -9,5 +9,5 @@ function testPDOStatementGetIterator(): void {
 	$pdo = new PDO('sqlite::memory:');
     $stmt = $pdo->query('SELECT 1');
 
-	assertType('Iterator<mixed, array<int|string, mixed>>', $stmt->getIterator());
+	assertType('Iterator<mixed, mixed>', $stmt->getIterator());
 }

tests/PHPStan/Rules/PhpDoc/InvalidPhpDocVarTagTypeRuleTest.php

@@ -170,6 +170,11 @@ public function testBug6348(): void
 		$this->analyse([__DIR__ . '/data/bug-6348.php'], []);
 	}
 
+	public function testBug14206(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-14206.php'], []);
+	}
+
 	public function testBug9055(): void
 	{
 		$this->analyse([__DIR__ . '/data/bug-9055.php'], [

tests/PHPStan/Rules/PhpDoc/data/bug-14206.php

@@ -0,0 +1,32 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14206;
+
+use PDO;
+use PDOStatement;
+
+class Test
+{
+	public function test(PDO $db): void
+	{
+		/** @var PDOStatement<int,string> */
+		$statement = $db->prepare('SELECT foo FROM bar');
+		$statement->setFetchMode(PDO::FETCH_COLUMN, 0);
+		$statement->execute();
+	}
+
+	public function test2(PDO $db): void
+	{
+		/** @var PDOStatement<int,array<string>> */
+		$statement = $db->prepare('SELECT foo FROM bar');
+		$statement->execute();
+	}
+
+	public function test3(PDO $db): void
+	{
+		/** @var PDOStatement<int,object> */
+		$statement = $db->prepare('SELECT foo FROM bar');
+		$statement->setFetchMode(PDO::FETCH_OBJ, 0);
+		$statement->execute();
+	}
+}

tests/PHPStan/Rules/Properties/AccessPropertiesRuleTest.php

@@ -1183,6 +1183,14 @@ public function testBug11289(): void
 		$this->analyse([__DIR__ . '/data/bug-11289.php'], []);
 	}
 
+	public function testBug9120(): void
+	{
+		$this->checkThisOnly = false;
+		$this->checkUnionTypes = true;
+		$this->checkDynamicProperties = false;
+		$this->analyse([__DIR__ . '/data/bug-9120.php'], []);
+	}
+
 	public function testBug8668(): void
 	{
 		$this->checkThisOnly = false;

tests/PHPStan/Rules/Properties/data/bug-9120.php

@@ -0,0 +1,19 @@
+<?php declare(strict_types = 1);
+
+namespace Bug9120;
+
+function do_something(): void
+{
+	$db = new \PDO('connection-string');
+
+	$statement = $db->query('sql-query');
+	if ($statement !== false)
+	{
+		$statement->setFetchMode(\PDO::FETCH_OBJ);
+
+		foreach ($statement as $tmpObject)
+		{
+			echo $tmpObject->mycolumn;
+		}
+	}
+}