Skip to content

Commit 82945c6

Browse files
committed
default to maybe
1 parent 250133c commit 82945c6

8 files changed

Lines changed: 12 additions & 12 deletions

src/Reflection/ExtendedCallableFunctionVariant.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ public function __construct(
3737
private array $usedVariables,
3838
private TrinaryLogic $acceptsNamedArguments,
3939
private TrinaryLogic $mustUseReturnValue,
40+
private TrinaryLogic $isBuiltinCallable,
4041
private ?Assertions $assertions = null,
41-
private ?TrinaryLogic $isBuiltinCallable = null,
4242
)
4343
{
4444
parent::__construct(
@@ -95,7 +95,7 @@ public function getAsserts(): Assertions
9595

9696
public function isBuiltin(): TrinaryLogic
9797
{
98-
return $this->isBuiltinCallable ?? TrinaryLogic::createNo();
98+
return $this->isBuiltinCallable;
9999
}
100100

101101
}

src/Reflection/GenericParametersAcceptorResolver.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,8 @@ public static function resolve(array $argTypes, ParametersAcceptor $parametersAc
130130
$originalParametersAcceptor->getUsedVariables(),
131131
$originalParametersAcceptor->acceptsNamedArguments(),
132132
$originalParametersAcceptor->mustUseReturnValue(),
133-
$originalParametersAcceptor->getAsserts(),
134133
$originalParametersAcceptor->isBuiltin(),
134+
$originalParametersAcceptor->getAsserts(),
135135
);
136136
}
137137

src/Reflection/InaccessibleMethod.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public function getAsserts(): Assertions
100100

101101
public function isBuiltin(): TrinaryLogic
102102
{
103-
return TrinaryLogic::createNo();
103+
return TrinaryLogic::createMaybe();
104104
}
105105

106106
}

src/Reflection/ParametersAcceptorSelector.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -736,7 +736,7 @@ public static function combineAcceptors(array $acceptors): ExtendedParametersAcc
736736
$usedVariables = [];
737737
$acceptsNamedArguments = TrinaryLogic::createNo();
738738
$mustUseReturnValue = TrinaryLogic::createMaybe();
739-
$isBuiltin = TrinaryLogic::createNo();
739+
$isBuiltin = TrinaryLogic::createMaybe();
740740

741741
foreach ($acceptors as $acceptor) {
742742
$returnTypes[] = $acceptor->getReturnType();
@@ -862,7 +862,7 @@ public static function combineAcceptors(array $acceptors): ExtendedParametersAcc
862862
$usedVariables,
863863
$acceptsNamedArguments,
864864
$mustUseReturnValue,
865-
isBuiltinCallable: $isBuiltin,
865+
$isBuiltin,
866866
);
867867
}
868868

@@ -900,8 +900,8 @@ private static function wrapAcceptor(ParametersAcceptor $acceptor): ExtendedPara
900900
$acceptor->getUsedVariables(),
901901
$acceptor->acceptsNamedArguments(),
902902
$acceptor->mustUseReturnValue(),
903-
$acceptor->getAsserts(),
904903
$acceptor->isBuiltin(),
904+
$acceptor->getAsserts(),
905905
);
906906
}
907907

src/Reflection/ResolvedFunctionVariantWithCallable.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ public function __construct(
2929
private array $usedVariables,
3030
private TrinaryLogic $acceptsNamedArguments,
3131
private TrinaryLogic $mustUseReturnValue,
32+
private TrinaryLogic $isBuiltinCallable,
3233
private ?Assertions $assertions = null,
33-
private ?TrinaryLogic $isBuiltinCallable = null,
3434
)
3535
{
3636
}
@@ -127,7 +127,7 @@ public function getAsserts(): Assertions
127127

128128
public function isBuiltin(): TrinaryLogic
129129
{
130-
return $this->isBuiltinCallable ?? TrinaryLogic::createNo();
130+
return $this->isBuiltinCallable;
131131
}
132132

133133
}

src/Reflection/TrivialParametersAcceptor.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ public function getAsserts(): Assertions
110110

111111
public function isBuiltin(): TrinaryLogic
112112
{
113-
return TrinaryLogic::createNo();
113+
return TrinaryLogic::createMaybe();
114114
}
115115

116116
}

src/Type/CallableType.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,7 @@ public function getAsserts(): Assertions
407407

408408
public function isBuiltin(): TrinaryLogic
409409
{
410-
return TrinaryLogic::createNo();
410+
return TrinaryLogic::createMaybe();
411411
}
412412

413413
public function toNumber(): Type

src/Type/ClosureType.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ public function getAsserts(): Assertions
140140

141141
public function isBuiltin(): TrinaryLogic
142142
{
143-
return TrinaryLogic::createNo();
143+
return TrinaryLogic::createMaybe();
144144
}
145145

146146
/**

0 commit comments

Comments
 (0)