Fix phpstan/phpstan#14394: NAN ==/=== anything is always evaluated as false

- Added containsNan() helper in InitializerExprTypeResolver to recursively
  check if a type (including constant arrays) contains NAN
- resolveIdenticalType() and resolveEqualType() now return always-false
  when either operand contains NAN
- Updated bug-11054 test expectations: [NAN] === mixed is now correctly
  reported as always false (matching PHP runtime behavior)
- New regression test in tests/PHPStan/Rules/Comparison/data/bug-14394.php

Author: VincentLanglet

src/Reflection/InitializerExprTypeResolver.php

@@ -114,6 +114,7 @@
 use function is_finite;
 use function is_float;
 use function is_int;
+use function is_nan;
 use function is_numeric;
 use function is_string;
 use function max;
@@ -1944,6 +1945,10 @@ public function resolveIdenticalType(Type $leftType, Type $rightType): TypeResul
 			return new TypeResult(new ConstantBooleanType(false), []);
 		}
 
+		if ($this->containsNan($leftType) || $this->containsNan($rightType)) {
+			return new TypeResult(new ConstantBooleanType(false), []);
+		}
+
 		if ($leftType instanceof ConstantScalarType && $rightType instanceof ConstantScalarType) {
 			return new TypeResult(new ConstantBooleanType($leftType->getValue() === $rightType->getValue()), []);
 		}
@@ -1972,6 +1977,10 @@ public function resolveIdenticalType(Type $leftType, Type $rightType): TypeResul
 	 */
 	public function resolveEqualType(Type $leftType, Type $rightType): TypeResult
 	{
+		if ($this->containsNan($leftType) || $this->containsNan($rightType)) {
+			return new TypeResult(new ConstantBooleanType(false), []);
+		}
+
 		if (
 			($leftType->isEnum()->yes() && $rightType->isTrue()->no())
 			|| ($rightType->isEnum()->yes() && $leftType->isTrue()->no())
@@ -2061,6 +2070,23 @@ private function resolveConstantArrayTypeComparison(ConstantArrayType $leftType,
 		return new TypeResult($resultType->toBoolean(), []);
 	}
 
+	private function containsNan(Type $type): bool
+	{
+		if ($type instanceof ConstantFloatType && is_nan($type->getValue())) {
+			return true;
+		}
+
+		foreach ($type->getConstantArrays() as $constantArray) {
+			foreach ($constantArray->getValueTypes() as $valueType) {
+				if ($this->containsNan($valueType)) {
+					return true;
+				}
+			}
+		}
+
+		return false;
+	}
+
 	/**
 	 * @param BinaryOp\Plus|BinaryOp\Minus|BinaryOp\Mul|BinaryOp\Div|BinaryOp\ShiftLeft|BinaryOp\ShiftRight $expr
 	 */

tests/PHPStan/Rules/Comparison/ConstantLooseComparisonRuleTest.php

@@ -248,4 +248,19 @@ public function testBug13098(): void
 		$this->analyse([__DIR__ . '/data/bug-13098.php'], []);
 	}
 
+	public function testBug14394(): void
+	{
+		$this->treatPhpDocTypesAsCertain = true;
+		$this->analyse([__DIR__ . '/data/bug-14394.php'], [
+			[
+				'Loose comparison using == between float and NAN will always evaluate to false.',
+				8,
+			],
+			[
+				'Loose comparison using == between list<mixed> and array{NAN} will always evaluate to false.',
+				10,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Comparison/StrictComparisonOfDifferentTypesRuleTest.php

@@ -1164,11 +1164,37 @@ public function testPossiblyImpureTip(): void
 	public function testBug11054(): void
 	{
 		$this->analyse([__DIR__ . '/data/bug-11054.php'], [
+			[
+				'Strict comparison using === between mixed and array{NAN} will always evaluate to false.',
+				24,
+			],
+			[
+				'Strict comparison using === between mixed and array{NAN} will always evaluate to false.',
+				28,
+			],
 			[
 				'Strict comparison using === between mixed and array{INF} will always evaluate to false.',
 				47,
 				'Type array{INF} has already been eliminated from mixed.',
 			],
+			[
+				'Strict comparison using === between mixed and array{NAN} will always evaluate to false.',
+				55,
+			],
+		]);
+	}
+
+	public function testBug14394(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-14394.php'], [
+			[
+				'Strict comparison using === between float and NAN will always evaluate to false.',
+				9,
+			],
+			[
+				'Strict comparison using === between list<mixed> and array{NAN} will always evaluate to false.',
+				11,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Comparison/data/bug-14394.php

@@ -0,0 +1,13 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14394;
+
+class Cl {
+	/** @param list<mixed> $v2 */
+	public static function test(float $v1, array $v2): void {
+		if ($v1 == NAN) { echo "never reached\n"; }
+		if ($v1 === NAN) { echo "never reached\n"; }
+		if ($v2 == [NAN]) { echo "never reached\n"; }
+		if ($v2 === [NAN]) { echo "never reached\n"; }
+	}
+}