Fix false positive dead catch for ReflectionMethod::invoke/invokeArgs

- Added ReflectionMethodInvokeMethodThrowTypeExtension to declare that
  ReflectionMethod::invoke(), ReflectionMethod::invokeArgs(),
  ReflectionFunction::invoke(), and ReflectionFunction::invokeArgs()
  can throw any Throwable, since they execute arbitrary user code
- New regression test in tests/PHPStan/Rules/Exceptions/data/bug-7719.php
- The root cause was that BetterReflection's adapter declared
  @throws ReflectionException on these methods, causing PHPStan to
  treat ReflectionException as the only possible thrown type

Closes phpstan/phpstan#7719

Author: phpstan-bot

phpstan-baseline.neon

@@ -1641,6 +1641,12 @@ parameters:
 			count: 1
 			path: src/Type/Php/ReflectionMethodConstructorThrowTypeExtension.php
 
+		-
+			rawMessage: 'Method PHPStan\Type\Php\ReflectionMethodInvokeMethodThrowTypeExtension::getThrowTypeFromMethodCall() never returns null so it can be removed from the return type.'
+			identifier: return.unusedType
+			count: 1
+			path: src/Type/Php/ReflectionMethodInvokeMethodThrowTypeExtension.php
+
 		-
 			rawMessage: 'Doing instanceof PHPStan\Type\Constant\ConstantStringType is error-prone and deprecated. Use Type::getConstantStrings() instead.'
 			identifier: phpstanApi.instanceofType

src/Type/Php/ReflectionMethodInvokeMethodThrowTypeExtension.php

@@ -0,0 +1,32 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Type\Php;
+
+use PhpParser\Node\Expr\MethodCall;
+use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredService;
+use PHPStan\Reflection\MethodReflection;
+use PHPStan\Type\DynamicMethodThrowTypeExtension;
+use PHPStan\Type\ObjectType;
+use PHPStan\Type\Type;
+use ReflectionFunction;
+use ReflectionMethod;
+use Throwable;
+use function in_array;
+
+#[AutowiredService]
+final class ReflectionMethodInvokeMethodThrowTypeExtension implements DynamicMethodThrowTypeExtension
+{
+
+	public function isMethodSupported(MethodReflection $methodReflection): bool
+	{
+		return in_array($methodReflection->getDeclaringClass()->getName(), [ReflectionMethod::class, ReflectionFunction::class], true)
+			&& in_array($methodReflection->getName(), ['invoke', 'invokeArgs'], true);
+	}
+
+	public function getThrowTypeFromMethodCall(MethodReflection $methodReflection, MethodCall $methodCall, Scope $scope): ?Type
+	{
+		return new ObjectType(Throwable::class);
+	}
+
+}

tests/PHPStan/Rules/Exceptions/CatchWithUnthrownExceptionRuleTest.php

@@ -604,6 +604,11 @@ public function testBug9568(): void
 		$this->analyse([__DIR__ . '/data/bug-9568.php'], []);
 	}
 
+	public function testBug7719(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-7719.php'], []);
+	}
+
 	#[RequiresPhp('>= 8.4')]
 	public function testPropertyHooks(): void
 	{

tests/PHPStan/Rules/Exceptions/data/bug-7719.php

@@ -0,0 +1,56 @@
+<?php declare(strict_types = 1);
+
+namespace Bug7719;
+
+class Endpoint {
+	public function run(int $id): int {
+		return $id;
+	}
+}
+
+class HelloWorld
+{
+	public function sayHello(Endpoint $endpoint, string $methodName): void
+	{
+		try {
+			$methodResponse = (new \ReflectionMethod($endpoint, $methodName))->invokeArgs($endpoint, ['id' => 2]);
+		} catch (\RuntimeException $e) {
+			echo $e->getMessage();
+			die;
+		}
+		var_dump($methodResponse);
+	}
+
+	public function sayHelloWithInvoke(Endpoint $endpoint, string $methodName): void
+	{
+		try {
+			$methodResponse = (new \ReflectionMethod($endpoint, $methodName))->invoke($endpoint, 2);
+		} catch (\RuntimeException $e) {
+			echo $e->getMessage();
+			die;
+		}
+		var_dump($methodResponse);
+	}
+
+	public function sayHelloWithFunction(string $functionName): void
+	{
+		try {
+			$result = (new \ReflectionFunction($functionName))->invokeArgs([1, 2]);
+		} catch (\RuntimeException $e) {
+			echo $e->getMessage();
+			die;
+		}
+		var_dump($result);
+	}
+
+	public function sayHelloWithFunctionInvoke(string $functionName): void
+	{
+		try {
+			$result = (new \ReflectionFunction($functionName))->invoke(1, 2);
+		} catch (\RuntimeException $e) {
+			echo $e->getMessage();
+			die;
+		}
+		var_dump($result);
+	}
+}