Move $isNonEmpty computation inside the if block where it is used

phpstan-bot · claude · phpstan-bot · commit 8f3e2065ca5d · 2026-05-01T17:43:46.000Z
Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/src/Type/Php/ImplodeFunctionReturnTypeExtension.php b/src/Type/Php/ImplodeFunctionReturnTypeExtension.php
@@ -61,8 +61,8 @@ public function getTypeFromFunctionCall(
 
 	private function implode(Type $arrayType, Type $separatorType): Type
 	{
-		$isNonEmpty = $arrayType->isIterableAtLeastOnce()->yes();
 		if (count($arrayType->getConstantArrays()) > 0 && count($separatorType->getConstantStrings()) > 0) {
+			$isNonEmpty = $arrayType->isIterableAtLeastOnce()->yes();
 			$result = [];
 			foreach ($separatorType->getConstantStrings() as $separator) {
 				foreach ($arrayType->getConstantArrays() as $constantArray) {

Original file line number	Diff line number	Diff line change
`@@ -61,8 +61,8 @@ public function getTypeFromFunctionCall(`
`61`	`61`
`62`	`62`	`private function implode(Type $arrayType, Type $separatorType): Type`
`63`	`63`	`{`
`64`		`- $isNonEmpty = $arrayType->isIterableAtLeastOnce()->yes();`
`65`	`64`	`if (count($arrayType->getConstantArrays()) > 0 && count($separatorType->getConstantStrings()) > 0) {`
	`65`	`+ $isNonEmpty = $arrayType->isIterableAtLeastOnce()->yes();`
`66`	`66`	`$result = [];`
`67`	`67`	`foreach ($separatorType->getConstantStrings() as $separator) {`
`68`	`68`	`foreach ($arrayType->getConstantArrays() as $constantArray) {`