Fix

Author: VincentLanglet

src/Analyser/ArgumentsNormalizer.php

@@ -22,7 +22,9 @@
 use function array_keys;
 use function array_values;
 use function count;
+use function key;
 use function ksort;
+use function is_string;
 use function max;
 use function sprintf;
 
@@ -120,16 +122,17 @@ public static function reorderCallUserFuncArrayArguments(
 				}
 			}
 
-			if ($argsArrayArg === null) {
-				if ($arg->name === null && $i === 1) {
-					$argsArrayArg = $arg;
-					continue;
-				}
-				if ($arg->name !== null && $arg->name->toString() === 'args') {
-					$argsArrayArg = $arg;
-					continue;
-				}
+			if ($argsArrayArg !== null) {
+				continue;
 			}
+			if ($arg->name === null && $i === 1) {
+				$argsArrayArg = $arg;
+				continue;
+			}
+			if ($arg->name === null || $arg->name->toString() !== 'args') {
+				continue;
+			}
+			$argsArrayArg = $arg;
 		}
 
 		if ($callbackArg === null || $argsArrayArg === null) {
@@ -149,8 +152,11 @@ public static function reorderCallUserFuncArrayArguments(
 		foreach ($argsArrayArg->value->items as $item) {
 			$key = null;
 			if ($item->key instanceof String_) {
-				/** @var int|string $offsetValue */
+				/** @var int|string $key */
 				$key = key([$item->key->value => null]);
+				if ($key === '') {
+					return null;
+				}
 			} elseif ($item->key !== null && !$item->key instanceof Int_) {
 				// Dynamic key, we cannot be sure.
 				return null;
@@ -161,7 +167,7 @@ public static function reorderCallUserFuncArrayArguments(
 				$item->byRef,
 				$item->unpack,
 				$item->getAttributes(),
-				\is_string($key) ? new Identifier($key) : null,
+				is_string($key) ? new Identifier($key) : null,
 			);
 		}
 

src/Rules/Functions/CallUserFuncRule.php

@@ -11,8 +11,8 @@
 use PHPStan\Rules\FunctionCallParametersCheck;
 use PHPStan\Rules\Rule;
 use function count;
-use function ucfirst;
 use function sprintf;
+use function ucfirst;
 
 /**
  * @implements Rule<FuncCall>

tests/PHPStan/Rules/Functions/data/call-user-func-array.php

@@ -53,6 +53,8 @@ public function doMore(): void
 		call_user_func_array($f, ['1' => 'foo']); // Same as call_user_func_array($f, ['foo'])
 		call_user_func_array($f, [1 => 42]); // Same as call_user_func_array($f, [42])
 		call_user_func_array($f, ['1' => 42]); // Same as call_user_func_array($f, [42])
+
+		call_user_func_array($f, ['' => 42]); // Could be reported but should at least not crash PHPStan
 	}
 
 }