more tests

Author: staabm

tests/PHPStan/Analyser/NodeScopeResolverTest.php

@@ -248,6 +248,7 @@ private static function findTestFiles(): iterable
 		yield __DIR__ . '/../Rules/Classes/data/bug-11591-property-tag.php';
 		yield __DIR__ . '/../Rules/Classes/data/mixin-trait-use.php';
 
+		yield __DIR__ . '/../Rules/Arrays/data/bug-14234.php';
 		yield __DIR__ . '/../Rules/Arrays/data/bug-11679.php';
 		yield __DIR__ . '/../Rules/Methods/data/bug-4801.php';
 		yield __DIR__ . '/../Rules/Arrays/data/narrow-superglobal.php';

tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php

@@ -1193,7 +1193,12 @@ public function testBug14234(): void
 	{
 		$this->reportPossiblyNonexistentGeneralArrayOffset = true;
 
-		$this->analyse([__DIR__ . '/data/bug-14234.php'], []);
+		$this->analyse([__DIR__ . '/data/bug-14234.php'], [
+			[
+				'Offset int<0, max> might not exist on array.',
+				48,
+			],
+		]);
 	}
 
 }

tests/PHPStan/Rules/Arrays/data/bug-14234.php

@@ -2,9 +2,12 @@
 
 namespace Bug14234;
 
+use function PHPStan\Testing\assertType;
+
 function getShortenedPath(string $identifier): string
 {
 	$parts = explode('/', $identifier);
+	assertType('non-empty-list<string>', $parts);
 
 	for ($i = 0; $i < count($parts) - 1; $i++) {
 		$parts[$i] = substr($parts[$i], 0, 1);
@@ -16,10 +19,34 @@ function getShortenedPath(string $identifier): string
 function getShortenedPath2(string $identifier): string
 {
 	$parts = explode('/', $identifier);
+	assertType('non-empty-list<string>', $parts);
 
 	for ($i = 0; $i < count($parts); $i++) {
 		$parts[$i] = substr($parts[$i], 0, 1);
 	}
 
 	return implode("/", $parts);
 }
+
+function getShortenedPath3(string $identifier): string
+{
+	$parts = explode('/', $identifier);
+	assertType('non-empty-list<string>', $parts);
+
+	for ($i = 0; $i < count($parts) - 4; $i++) {
+		$parts[$i] = substr($parts[$i], 0, 1);
+	}
+
+	return implode("/", $parts);
+}
+
+function getShortenedPath4(array $parts): string
+{
+	assertType('array', $parts);
+
+	for ($i = 0; $i < count($parts) - 4; $i++) {
+		$parts[$i] = substr($parts[$i], 0, 1);
+	}
+
+	return implode("/", $parts);
+}