Use early exit in resolveReflectionAttributeType to reduce nesting

phpstan-bot · claude · staabm · commit a0c7ed7ab687 · 2026-04-17T16:10:10.000+02:00
Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/src/Type/Php/ReflectionGetAttributesMethodReturnTypeExtension.php b/src/Type/Php/ReflectionGetAttributesMethodReturnTypeExtension.php
@@ -57,9 +57,11 @@ private function resolveReflectionAttributeType(MethodReflection $methodReflecti
 
 		$valueTypes = [];
 		foreach ($returnType->getIterableValueType()->getObjectClassNames() as $className) {
-			if ($nativeReflectionAttributeType->isSuperTypeOf(new ObjectType($className))->yes()) {
-				$valueTypes[] = new GenericObjectType($className, [$classType]);
+			if (!$nativeReflectionAttributeType->isSuperTypeOf(new ObjectType($className))->yes()) {
+				continue;
 			}
+
+			$valueTypes[] = new GenericObjectType($className, [$classType]);
 		}
 
 		if (count($valueTypes) === 0) {

Original file line number	Diff line number	Diff line change
`@@ -57,9 +57,11 @@ private function resolveReflectionAttributeType(MethodReflection $methodReflecti`
`57`	`57`
`58`	`58`	`$valueTypes = [];`
`59`	`59`	`foreach ($returnType->getIterableValueType()->getObjectClassNames() as $className) {`
`60`		`- if ($nativeReflectionAttributeType->isSuperTypeOf(new ObjectType($className))->yes()) {`
`61`		`- $valueTypes[] = new GenericObjectType($className, [$classType]);`
	`60`	`+ if (!$nativeReflectionAttributeType->isSuperTypeOf(new ObjectType($className))->yes()) {`
	`61`	`+ continue;`
`62`	`62`	`}`
	`63`	`+`
	`64`	`+ $valueTypes[] = new GenericObjectType($className, [$classType]);`
`63`	`65`	`}`
`64`	`66`
`65`	`67`	`if (count($valueTypes) === 0) {`