Fix get defined vars return type (#4632)

Author: VincentLanglet

src/Type/Php/GetDefinedVarsFunctionReturnTypeExtension.php

@@ -35,6 +35,10 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
 		$typeBuilder = ConstantArrayTypeBuilder::createEmpty();
 
 		foreach ($scope->getDefinedVariables() as $variable) {
+			if ($variable === 'this') {
+				continue;
+			}
+
 			$typeBuilder->setOffsetValueType(new ConstantStringType($variable), $scope->getVariableType($variable), false);
 		}
 

tests/PHPStan/Analyser/nsrt/get-defined-vars.php

@@ -44,3 +44,13 @@ function doRandom(int $param) {
 	}
 	assertType('array{param: int, local: \'foo\', random2?: \'baz\', random1?: \'bar\'}', get_defined_vars());
 }
+
+class A
+{
+	public function test(): void
+	{
+		$local = 'foo';
+
+		assertType('array{local: \'foo\'}', get_defined_vars());
+	}
+}

tests/PHPStan/Rules/Methods/CallMethodsRuleTest.php

@@ -3674,6 +3674,16 @@ public function testBug3396(): void
 		$this->analyse([__DIR__ . '/data/bug-3396.php'], []);
 	}
 
+	#[RequiresPhp('>= 8.0')]
+	public function testBug13881(): void
+	{
+		$this->checkThisOnly = false;
+		$this->checkNullables = true;
+		$this->checkUnionTypes = true;
+		$this->checkExplicitMixed = true;
+		$this->analyse([__DIR__ . '/data/bug-13881.php'], []);
+	}
+
 	public function testBug13511(): void
 	{
 		$this->checkThisOnly = false;

tests/PHPStan/Rules/Methods/data/bug-13881.php

@@ -0,0 +1,34 @@
+<?php
+
+namespace Bug13881;
+
+class A {
+
+	public function test(string $functionArg): void {
+		$localVariable = "test";
+
+		$map = [
+			"var" => "1",
+		];
+
+		$values = get_defined_vars();
+
+		unset($values["map"]);
+		unset($values["functionArg"]);
+		unset($values["localVariable"]);
+		//unset($values["this"]);
+
+		foreach ($map as $field => $val) {
+			$values[$field] = $val;
+		}
+
+		$this->varDump(...$values);
+	}
+
+	public function varDump(mixed $var): void {
+		var_dump($var);
+	}
+}
+
+$a = new A();
+$a->test("a");