Add tests

Author: VincentLanglet

tests/PHPStan/Rules/Variables/DefinedVariableRuleTest.php

@@ -1442,15 +1442,15 @@ public function testBug14323(): void
 		$this->analyse([__DIR__ . '/data/bug-14323.php'], [
 			[
 				'Variable $command might not be defined.',
-				40,
+				24,
 			],
 			[
 				'Variable $command might not be defined.',
-				66,
+				50,
 			],
 			[
 				'Variable $command might not be defined.',
-				118,
+				119,
 			],
 		]);
 	}

tests/PHPStan/Rules/Variables/data/bug-14323.php

@@ -9,22 +9,6 @@ class Process {
 	public function __construct(array $a) {}
 }
 
-class Process2 {
-	/**
-	 * @param array<string> $a
-	 * @throws ProcessFailedException
-	 */
-	public function __construct(array $a) {}
-}
-
-class Process3 {
-	/**
-	 * @param array<string> $a
-	 * @throws void
-	 */
-	public function __construct(array $a) {}
-}
-
 abstract class DbCommand
 {
     /**
@@ -77,6 +61,15 @@ public function handle()
     abstract public function getCommand();
 }
 
+
+class Process2 {
+	/**
+	 * @param array<string> $a
+	 * @throws ProcessFailedException
+	 */
+	public function __construct(array $a) {}
+}
+
 abstract class DbCommand3
 {
     /**
@@ -103,6 +96,14 @@ public function handle()
     abstract public function getCommand();
 }
 
+class Process3 {
+	/**
+	 * @param array<string> $a
+	 * @throws void
+	 */
+	public function __construct(array $a) {}
+}
+
 abstract class DbCommand4
 {
     /**
@@ -128,3 +129,84 @@ public function handle()
      */
     abstract public function getCommand();
 }
+
+class Process4 {
+	/**
+	 * @param array<string> $a
+	 *
+	 * @throws \LogicException
+	 */
+	public function __construct(array $a) {}
+
+	/**
+	 * @throws ProcessFailedException
+	 * @throws \LogicException
+	 */
+	public function mustRun(): int {}
+}
+
+abstract class DbCommand5
+{
+	/**
+	 * @return int
+	 */
+	public function handle()
+	{
+		try {
+			(new Process4(
+				array_merge([$command = $this->getCommand()]),
+			))->mustRun();
+		} catch (ProcessFailedException $e) {
+			echo ("{$command} not found in path.");
+
+			return 1;
+		}
+
+		return 0;
+	}
+
+	/**
+	 * @return string
+	 */
+	abstract public function getCommand();
+}
+
+class Process5 {
+	/**
+	 * @param array<string> $a
+	 *
+	 * @throws \LogicException
+	 */
+	public function __construct(array $a) {}
+
+	/**
+	 * @throws ProcessFailedException
+	 */
+	public function mustRun(): int {}
+}
+
+abstract class DbCommand6
+{
+	/**
+	 * @return int
+	 */
+	public function handle()
+	{
+		try {
+			(new Process5(
+				array_merge([$command = $this->getCommand()]),
+			))->mustRun();
+		} catch (ProcessFailedException $e) {
+			echo ("{$command} not found in path.");
+
+			return 1;
+		}
+
+		return 0;
+	}
+
+	/**
+	 * @return string
+	 */
+	abstract public function getCommand();
+}