Fix phpstan/phpstan#14241: Report error for auto-global variable in parameters

- Added SuperGlobalParameterRule to detect superglobal variable names used as function/method/closure parameters
- PHP throws a fatal error for this (e.g. `function doFoo($_FILES): void {}`), but PHPStan was not reporting it
- New regression test in tests/PHPStan/Rules/Functions/data/bug-14241.php
- Excluded test data file from Makefile lint step since PHP cannot parse files with superglobal parameters

Author: phpstan-bot

Makefile

@@ -127,6 +127,7 @@ lint:
 		--exclude tests/PHPStan/Rules/Properties/data/override-attr-on-property.php \
 		--exclude tests/PHPStan/Rules/Properties/data/property-override-attr.php \
 		--exclude tests/PHPStan/Rules/Operators/data/bug-3585.php \
+		--exclude tests/PHPStan/Rules/Functions/data/bug-14241.php \
 		src tests
 
 install-paratest:

src/Rules/Functions/SuperGlobalParameterRule.php

@@ -0,0 +1,55 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Functions;
+
+use PhpParser\Node;
+use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\RegisteredRule;
+use PHPStan\Rules\Rule;
+use PHPStan\Rules\RuleErrorBuilder;
+use function in_array;
+use function is_string;
+use function sprintf;
+
+/**
+ * @implements Rule<Node\FunctionLike>
+ */
+#[RegisteredRule(level: 0)]
+final class SuperGlobalParameterRule implements Rule
+{
+
+	public function getNodeType(): string
+	{
+		return Node\FunctionLike::class;
+	}
+
+	public function processNode(Node $node, Scope $scope): array
+	{
+		$errors = [];
+
+		foreach ($node->getParams() as $param) {
+			if (!$param->var instanceof Node\Expr\Variable) {
+				continue;
+			}
+
+			if (!is_string($param->var->name)) {
+				continue;
+			}
+
+			$var = $param->var->name;
+
+			if (!in_array($var, Scope::SUPERGLOBAL_VARIABLES, true)) {
+				continue;
+			}
+
+			$errors[] = RuleErrorBuilder::message(sprintf('Cannot re-assign auto-global variable $%s.', $var))
+				->line($param->getStartLine())
+				->identifier('parameter.superGlobal')
+				->nonIgnorable()
+				->build();
+		}
+
+		return $errors;
+	}
+
+}

tests/PHPStan/Rules/Functions/SuperGlobalParameterRuleTest.php

@@ -0,0 +1,61 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Functions;
+
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+
+/**
+ * @extends RuleTestCase<SuperGlobalParameterRule>
+ */
+class SuperGlobalParameterRuleTest extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return new SuperGlobalParameterRule();
+	}
+
+	public function testRule(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-14241.php'], [
+			[
+				'Cannot re-assign auto-global variable $_FILES.',
+				5,
+			],
+			[
+				'Cannot re-assign auto-global variable $_GET.',
+				7,
+			],
+			[
+				'Cannot re-assign auto-global variable $_POST.',
+				7,
+			],
+			[
+				'Cannot re-assign auto-global variable $_SERVER.',
+				13,
+			],
+			[
+				'Cannot re-assign auto-global variable $_SESSION.',
+				15,
+			],
+			[
+				'Cannot re-assign auto-global variable $_COOKIE.',
+				18,
+			],
+			[
+				'Cannot re-assign auto-global variable $_REQUEST.',
+				20,
+			],
+			[
+				'Cannot re-assign auto-global variable $_ENV.',
+				22,
+			],
+			[
+				'Cannot re-assign auto-global variable $GLOBALS.',
+				24,
+			],
+		]);
+	}
+
+}

tests/PHPStan/Rules/Functions/data/bug-14241.php

@@ -0,0 +1,24 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14241;
+
+function doFoo($_FILES): void {}
+
+function doBar($_GET, $_POST): void {}
+
+function doBaz($ok): void {}
+
+class Foo
+{
+	public function doFoo($_SERVER): void {}
+
+	public static function doBar($_SESSION): void {}
+}
+
+$f = function ($_COOKIE): void {};
+
+$g = fn ($_REQUEST) => $_REQUEST;
+
+function doQux($_ENV): void {}
+
+function doQuux($GLOBALS): void {}