Remove redundant phpVersion check and add union type tests

The phpVersion->throwsOnStringCast() check is unnecessary because the
toString resolution already handles the PHP version gate internally.
Also adds regression tests for echo on union types (int|Foo, int|Bar,
int|Baz) as requested in review.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: phpstan-bot

src/Analyser/NodeScopeResolver.php

@@ -110,7 +110,6 @@
 use PHPStan\Parser\ImmediatelyInvokedClosureVisitor;
 use PHPStan\Parser\LineAttributesVisitor;
 use PHPStan\Parser\Parser;
-use PHPStan\Php\PhpVersion;
 use PHPStan\PhpDoc\PhpDocInheritanceResolver;
 use PHPStan\PhpDoc\ResolvedPhpDocBlock;
 use PHPStan\PhpDoc\Tag\VarTag;
@@ -863,24 +862,21 @@ public function processStmtNode(
 			$hasYield = false;
 			$throwPoints = [];
 			$isAlwaysTerminating = false;
-			$phpVersion = $this->container->getByType(PhpVersion::class);
 			foreach ($stmt->exprs as $echoExpr) {
 				$result = $this->processExprNode($stmt, $echoExpr, $scope, $storage, $nodeCallback, ExpressionContext::createDeep());
 				$throwPoints = array_merge($throwPoints, $result->getThrowPoints());
-				if ($phpVersion->throwsOnStringCast()) {
-					$exprType = $scope->getType($echoExpr);
-					$toStringMethod = $scope->getMethodReflection($exprType, '__toString');
-					if ($toStringMethod !== null) {
-						$toStringResult = $this->processExprNode(
-							$stmt,
-							new Expr\MethodCall($echoExpr, new Identifier('__toString')),
-							$scope,
-							new ExpressionResultStorage(),
-							new NoopNodeCallback(),
-							ExpressionContext::createDeep(),
-						);
-						$throwPoints = array_merge($throwPoints, $toStringResult->getThrowPoints());
-					}
+				$exprType = $scope->getType($echoExpr);
+				$toStringMethod = $scope->getMethodReflection($exprType, '__toString');
+				if ($toStringMethod !== null) {
+					$toStringResult = $this->processExprNode(
+						$stmt,
+						new Expr\MethodCall($echoExpr, new Identifier('__toString')),
+						$scope,
+						new ExpressionResultStorage(),
+						new NoopNodeCallback(),
+						ExpressionContext::createDeep(),
+					);
+					$throwPoints = array_merge($throwPoints, $toStringResult->getThrowPoints());
 				}
 				$scope = $result->getScope();
 				$hasYield = $hasYield || $result->hasYield();

tests/PHPStan/Rules/Exceptions/CatchWithUnthrownExceptionRuleTest.php

@@ -759,6 +759,10 @@ public function testBug5952(): void
 				'Dead catch - Exception is never thrown in the try block.',
 				57,
 			],
+			[
+				'Dead catch - Exception is never thrown in the try block.',
+				84,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Exceptions/data/bug-5952.php

@@ -57,3 +57,30 @@ public function __toString(): string
 } catch (\Exception $e) {
 	echo "Should not be printed";
 }
+
+/** @var int|Foo $intOrFoo */
+$intOrFoo = doFoo();
+
+try {
+	echo $intOrFoo;
+} catch (\Exception $e) {
+	echo "Should be printed";
+}
+
+/** @var int|Bar $intOrBar */
+$intOrBar = doFoo();
+
+try {
+	echo $intOrBar;
+} catch (\Exception $e) {
+	echo "Should be printed";
+}
+
+/** @var int|Baz $intOrBaz */
+$intOrBaz = doFoo();
+
+try {
+	echo $intOrBaz;
+} catch (\Exception $e) {
+	echo "Should not be printed";
+}