resolveType for (unset) cast

Author: ondrejmirtes

src/Analyser/ExprHandler/CastHandler.php

@@ -13,6 +13,7 @@
 use PHPStan\Analyser\NodeScopeResolver;
 use PHPStan\DependencyInjection\AutowiredService;
 use PHPStan\Reflection\InitializerExprTypeResolver;
+use PHPStan\Type\NullType;
 use PHPStan\Type\Type;
 
 /**
@@ -54,6 +55,10 @@ public function processExpr(NodeScopeResolver $nodeScopeResolver, Stmt $stmt, Ex
 	 */
 	public function resolveType(MutatingScope $scope, Expr $expr): Type
 	{
+		if ($expr instanceof Cast\Unset_) {
+			return new NullType();
+		}
+
 		return $this->initializerExprTypeResolver->getCastType($expr, static fn (Expr $expr): Type => $scope->getType($expr));
 	}
 

src/Analyser/MutatingScope.php

@@ -8,7 +8,6 @@
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\Array_;
 use PhpParser\Node\Expr\BinaryOp;
-use PhpParser\Node\Expr\Cast\Unset_;
 use PhpParser\Node\Expr\ConstFetch;
 use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Expr\Match_;
@@ -1071,10 +1070,6 @@ private function resolveType(string $exprString, Expr $node): Type
 			return $this->nativeTypesPromoted ? $node->getNativeExprType() : $node->getExprType();
 		}
 
-		if ($node instanceof Unset_) {
-			return new NullType();
-		}
-
 		if ($node instanceof MethodCall) {
 			$callType = $this->getMethodCallType($node);
 			if ($callType !== null) {