Fix phpstan/phpstan#11978: Intersection type method calls should not depend on ordering

- IntersectionTypeMethodReflection::getVariants() now picks the method with the most parameters instead of always using the first method
- Added regression test in tests/PHPStan/Rules/Methods/data/bug-11978.php
- The root cause was that the first method's parameter list was always used, so ViewA&ViewB would use ViewA's 0-param render() while ViewB&ViewA would use ViewB's 1-param render()

Author: VincentLanglet

src/Reflection/Type/IntersectionTypeMethodReflection.php

@@ -95,6 +95,19 @@ public function getVariants(): array
 		$returnType = TypeCombinator::intersect(...$returnTypes);
 		$phpDocReturnType = TypeCombinator::intersect(...$phpDocReturnTypes);
 		$nativeReturnType = TypeCombinator::intersect(...$nativeReturnTypes);
+		$methodWithMostParameters = $this->methods[0];
+		$maxParameters = 0;
+		foreach ($this->methods as $method) {
+			foreach ($method->getVariants() as $variant) {
+				if (count($variant->getParameters()) <= $maxParameters) {
+					continue;
+				}
+
+				$maxParameters = count($variant->getParameters());
+				$methodWithMostParameters = $method;
+			}
+		}
+
 		return array_map(static fn (ExtendedParametersAcceptor $acceptor): ExtendedParametersAcceptor => new ExtendedFunctionVariant(
 			$acceptor->getTemplateTypeMap(),
 			$acceptor->getResolvedTemplateTypeMap(),
@@ -104,7 +117,7 @@ public function getVariants(): array
 			$phpDocReturnType,
 			$nativeReturnType,
 			$acceptor->getCallSiteVarianceMap(),
-		), $this->methods[0]->getVariants());
+		), $methodWithMostParameters->getVariants());
 	}
 
 	public function getOnlyVariant(): ExtendedParametersAcceptor

tests/PHPStan/Rules/Methods/CallMethodsRuleTest.php

@@ -3962,4 +3962,12 @@ public function testBug11463(): void
 		]);
 	}
 
+	public function testBug11978(): void
+	{
+		$this->checkThisOnly = false;
+		$this->checkNullables = true;
+		$this->checkUnionTypes = true;
+		$this->analyse([__DIR__ . '/data/bug-11978.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Methods/data/bug-11978.php

@@ -0,0 +1,28 @@
+<?php // lint >= 8.1
+
+declare(strict_types = 1);
+
+namespace Bug11978;
+
+interface ViewA {
+	public function render(): string;
+}
+interface ViewB {
+	public function render(string $foo = ''): string;
+}
+
+class Foo
+{
+	public function __construct(
+		private readonly ViewA&ViewB $view1,
+		private readonly ViewB&ViewA $view2,
+	) {}
+
+	public function renderFoo(string $foo): string
+	{
+		$a = $this->view1->render($foo);
+		$b = $this->view2->render($foo);
+
+		return $a . $b;
+	}
+}