Fix error reported on the wrong line

Author: VincentLanglet

src/Analyser/RuleErrorTransformer.php

@@ -14,6 +14,7 @@
 use PHPStan\Fixable\PhpPrinter;
 use PHPStan\Fixable\PhpPrinterIndentationDetectorVisitor;
 use PHPStan\Fixable\ReplacingNodeVisitor;
+use PHPStan\Node\PropertyAssignNode;
 use PHPStan\Node\VirtualNode;
 use PHPStan\Rules\FileRuleError;
 use PHPStan\Rules\FixableNodeRuleError;
@@ -55,7 +56,6 @@ public function transform(
 		Node $node,
 	): Error
 	{
-		$line = $node->getStartLine();
 		$canBeIgnored = true;
 		$fileName = $scope->getFileDescription();
 		$filePath = $scope->getFile();
@@ -75,6 +75,8 @@ public function transform(
 			&& $ruleError->getLine() !== -1
 		) {
 			$line = $ruleError->getLine();
+		} else {
+			$line = $this->getLineFromNode($node);
 		}
 		if (
 			$ruleError instanceof FileRuleError
@@ -166,4 +168,20 @@ public function transform(
 		);
 	}
 
+	private function getLineFromNode(Node $node): int
+	{
+		if ($node instanceof PropertyAssignNode) {
+			return $this->getLineFromNode($node->getPropertyFetch());
+		}
+
+		if (
+			$node instanceof Node\Expr\PropertyFetch
+			|| $node instanceof Node\Expr\MethodCall
+		) {
+			return $node->name->getStartLine();
+		}
+
+		return $node->getStartLine();
+	}
+
 }

tests/PHPStan/Rules/Methods/CallMethodsRuleTest.php

@@ -3844,6 +3844,19 @@ public function testBug12875(): void
 		$this->analyse([__DIR__ . '/data/bug-12875.php'], []);
 	}
 
+	public function testBug14150(): void
+	{
+		$this->checkThisOnly = false;
+		$this->checkNullables = true;
+		$this->checkUnionTypes = true;
+		$this->analyse([__DIR__ . '/data/bug-14150.php'], [
+			[
+				'Call to an undefined method Bug14150Method\HelloWorld::y().',
+				21,
+			],
+		]);
+	}
+
 	#[RequiresPhp('>= 8.1')]
 	public function testBug13805(): void
 	{

tests/PHPStan/Rules/Methods/data/bug-14150.php

@@ -0,0 +1,23 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14150Method;
+
+class HelloWorld
+{
+	public int $x = 5;
+
+	/**
+	 * @return $this
+	 */
+	public function x(): static
+	{
+		return $this;
+	}
+
+	public function testUnknownMethod(): void
+	{
+		$this
+			->x()
+			->y();
+	}
+}

tests/PHPStan/Rules/Properties/TypesAssignedToPropertiesRuleTest.php

@@ -986,6 +986,22 @@ public function testBug13654(): void
 		$this->analyse([__DIR__ . '/data/bug-13654.php'], []);
 	}
 
+	public function testBug14150(): void
+	{
+		$this->checkExplicitMixed = true;
+		$this->checkImplicitMixed = true;
+		$this->analyse([__DIR__ . '/data/bug-14150.php'], [
+			[
+				'Property Bug14150Properties\HelloWorld::$x (int) does not accept null.',
+				20,
+			],
+			[
+				'Property Bug14150Properties\HelloWorld::$x (int) does not accept null.',
+				27,
+			],
+		]);
+	}
+
 	#[RequiresPhp('>= 8.5')]
 	public function testCloneWith(): void
 	{

tests/PHPStan/Rules/Properties/data/bug-14150.php

@@ -0,0 +1,29 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14150Properties;
+
+class HelloWorld
+{
+	public int $x = 5;
+
+	/**
+	 * @return $this
+	 */
+	public function x(): static
+	{
+		return $this;
+	}
+
+	public function test3(): void
+	{
+		$this
+			->x = null;
+	}
+
+	public function test4(): void
+	{
+		$this
+			->x()
+			->x = null;
+	}
+}