Use per-class method reflection when resolving dynamic return type extensions on union types

- In `MethodCallReturnTypeHelper::methodCallReturnType()`, the per-class-name loop
  passed the union's combined `MethodReflection` to `isMethodSupported()` and
  `getTypeFromMethodCall()`/`getTypeFromStaticMethodCall()`. Extensions that check
  `$methodReflection->getDeclaringClass()->getName()` (e.g.
  `ReflectionGetAttributesMethodReturnTypeExtension`) only matched the declaring
  class of `UnionTypeMethodReflection::$methods[0]`, causing extensions for other
  union members to be skipped.
- Now create a per-class `ObjectType` and get the method reflection from it for each
  iteration, so each extension sees the correct declaring class.
- Also applies to the static method call branch in the same loop.

Author: phpstan-bot

src/Analyser/ExprHandler/Helper/MethodCallReturnTypeHelper.php

@@ -56,13 +56,18 @@ public function methodCallReturnType(
 		$allClassNames = $typeWithMethod->getObjectClassNames();
 		$handledClassNames = [];
 		foreach ($allClassNames as $className) {
+			$classType = new ObjectType($className);
+			if (!$classType->hasMethod($methodName)->yes()) {
+				continue;
+			}
+			$classMethodReflection = $classType->getMethod($methodName, $scope);
 			if ($normalizedMethodCall instanceof MethodCall) {
 				foreach ($this->dynamicReturnTypeExtensionRegistryProvider->getRegistry()->getDynamicMethodReturnTypeExtensionsForClass($className) as $dynamicMethodReturnTypeExtension) {
-					if (!$dynamicMethodReturnTypeExtension->isMethodSupported($methodReflection)) {
+					if (!$dynamicMethodReturnTypeExtension->isMethodSupported($classMethodReflection)) {
 						continue;
 					}
 
-					$resolvedType = $dynamicMethodReturnTypeExtension->getTypeFromMethodCall($methodReflection, $normalizedMethodCall, $scope);
+					$resolvedType = $dynamicMethodReturnTypeExtension->getTypeFromMethodCall($classMethodReflection, $normalizedMethodCall, $scope);
 					if ($resolvedType === null) {
 						continue;
 					}
@@ -72,12 +77,12 @@ public function methodCallReturnType(
 				}
 			} else {
 				foreach ($this->dynamicReturnTypeExtensionRegistryProvider->getRegistry()->getDynamicStaticMethodReturnTypeExtensionsForClass($className) as $dynamicStaticMethodReturnTypeExtension) {
-					if (!$dynamicStaticMethodReturnTypeExtension->isStaticMethodSupported($methodReflection)) {
+					if (!$dynamicStaticMethodReturnTypeExtension->isStaticMethodSupported($classMethodReflection)) {
 						continue;
 					}
 
 					$resolvedType = $dynamicStaticMethodReturnTypeExtension->getTypeFromStaticMethodCall(
-						$methodReflection,
+						$classMethodReflection,
 						$normalizedMethodCall,
 						$scope,
 					);

tests/PHPStan/Analyser/nsrt/bug-14466.php

@@ -0,0 +1,68 @@
+<?php // lint >= 8.0
+
+declare(strict_types = 1);
+
+namespace Bug14466;
+
+use ReflectionAttribute;
+use ReflectionClass;
+use ReflectionMethod;
+use function PHPStan\Testing\assertType;
+
+interface I
+{
+
+}
+
+class Bug
+{
+	/**
+	 * @param ReflectionClass<*> $object
+	 */
+	protected function c(ReflectionClass $object): void
+	{
+		$requirements = $object->getAttributes(I::class, ReflectionAttribute::IS_INSTANCEOF);
+
+		assertType('list<ReflectionAttribute<Bug14466\I>>', $requirements);
+	}
+
+	/**
+	 * @param ReflectionMethod $object
+	 */
+	protected function m(ReflectionMethod $object): void
+	{
+		$requirements = $object->getAttributes(I::class, ReflectionAttribute::IS_INSTANCEOF);
+
+		assertType('list<ReflectionAttribute<Bug14466\I>>', $requirements);
+	}
+
+	/**
+	 * @param ReflectionClass<*>|ReflectionMethod $object
+	 */
+	protected function classOrMethod(ReflectionClass|ReflectionMethod $object): void
+	{
+		$requirements = $object->getAttributes(I::class, ReflectionAttribute::IS_INSTANCEOF);
+
+		assertType('list<ReflectionAttribute<Bug14466\I>>', $requirements);
+	}
+
+	/**
+	 * @param ReflectionClass<*>|\ReflectionProperty $object
+	 */
+	protected function classOrProperty(ReflectionClass|\ReflectionProperty $object): void
+	{
+		$requirements = $object->getAttributes(I::class, ReflectionAttribute::IS_INSTANCEOF);
+
+		assertType('list<ReflectionAttribute<Bug14466\I>>', $requirements);
+	}
+
+	/**
+	 * @param ReflectionMethod|\ReflectionProperty $object
+	 */
+	protected function methodOrProperty(ReflectionMethod|\ReflectionProperty $object): void
+	{
+		$requirements = $object->getAttributes(I::class, ReflectionAttribute::IS_INSTANCEOF);
+
+		assertType('list<ReflectionAttribute<Bug14466\I>>', $requirements);
+	}
+}