Fix iterable<K,V> not accepted as array<K,V>|Traversable<K,V>

- Fixed IterableType::isSubTypeOf() to use GenericObjectType for the Traversable
  part of the decomposition instead of IntersectionType with plain ObjectType
- The plain ObjectType(Traversable) lost generic type parameters, causing subtype
  checks against GenericObjectType(Traversable, [K, V]) to return maybe instead of yes
- Consistent with how IterableType::tryRemove() already decomposes iterable
- New regression test in tests/PHPStan/Rules/Functions/data/bug-13247.php

Author: VincentLanglet

src/Type/IterableType.php

@@ -138,9 +138,9 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult
 		if ($otherType instanceof IntersectionType || $otherType instanceof UnionType) {
 			return $otherType->isSuperTypeOf(new UnionType([
 				new ArrayType($this->keyType, $this->itemType),
-				new IntersectionType([
-					new ObjectType(Traversable::class),
-					$this,
+				new GenericObjectType(Traversable::class, [
+					$this->keyType,
+					$this->itemType,
 				]),
 			]));
 		}

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

@@ -2735,4 +2735,9 @@ public function testBug10559(): void
 		$this->analyse([__DIR__ . '/data/bug-10559.php'], []);
 	}
 
+	public function testBug13247(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-13247.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Functions/data/bug-13247.php

@@ -0,0 +1,43 @@
+<?php // lint >= 8.0
+
+declare(strict_types = 1);
+
+namespace Bug13247;
+
+use Traversable;
+
+/**
+ * @param array<int, int>|Traversable<int, int> $input
+ *
+ * @return array<int, int>
+ */
+function as_array(array|Traversable $input): array {
+	return iter_as_array($input);
+}
+
+/**
+ * @param iterable<int, int> $input
+ *
+ * @return array<int, int>
+ */
+function iter_as_array(iterable $input): array {
+	return as_array($input);
+}
+
+/**
+ * @param array|Traversable $input
+ *
+ * @return array
+ */
+function as_array2(array|Traversable $input): array {
+	return iter_as_array2($input);
+}
+
+/**
+ * @param iterable $input
+ *
+ * @return array
+ */
+function iter_as_array2(iterable $input): array {
+	return as_array2($input);
+}