Store processedFiles in AnalysisResult, make analyse() return AnalysisResult again

Move processedFiles from a separate array return value into the AnalysisResult
DTO so that AnalyseApplication::analyse() returns AnalysisResult directly
instead of array{AnalysisResult, list<string>}.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: phpstan-bot

src/Command/AnalyseApplication.php

@@ -50,7 +50,6 @@ public function __construct(
 	/**
 	 * @param string[] $files
 	 * @param mixed[]|null $projectConfigArray
-	 * @return array{AnalysisResult, list<string>}
 	 */
 	public function analyse(
 		array $files,
@@ -64,7 +63,7 @@ public function analyse(
 		?string $tmpFile,
 		?string $insteadOfFile,
 		InputInterface $input,
-	): array
+	): AnalysisResult
 	{
 		$isResultCacheUsed = false;
 		$fileReplacements = [];
@@ -177,22 +176,20 @@ public function analyse(
 			$savedResultCache = $resultCacheResult->isSaved();
 		}
 
-		return [
-			new AnalysisResult(
-				$fileSpecificErrors,
-				$notFileSpecificErrors,
-				$internalErrors,
-				[],
-				$this->mapCollectedData($collectedData),
-				$defaultLevelUsed,
-				$projectConfigFile,
-				$savedResultCache,
-				$memoryUsageBytes,
-				$isResultCacheUsed,
-				$changedProjectExtensionFilesOutsideOfAnalysedPaths,
-			),
+		return new AnalysisResult(
+			$fileSpecificErrors,
+			$notFileSpecificErrors,
+			$internalErrors,
+			[],
+			$this->mapCollectedData($collectedData),
+			$defaultLevelUsed,
+			$projectConfigFile,
+			$savedResultCache,
+			$memoryUsageBytes,
+			$isResultCacheUsed,
+			$changedProjectExtensionFilesOutsideOfAnalysedPaths,
 			$processedFiles,
-		];
+		);
 	}
 
 	/**

src/Command/AnalyseCommand.php

@@ -341,7 +341,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 		}
 
 		try {
-			[$analysisResult, $processedFiles] = $application->analyse(
+			$analysisResult = $application->analyse(
 				$files,
 				$onlyFiles,
 				$inceptionResult->getStdOutput(),
@@ -459,7 +459,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 		}
 
 		if ($generateBaselineFile !== null) {
-			$this->runDiagnoseExtensions($container, $inceptionResult->getErrorOutput(), $processedFiles);
+			$this->runDiagnoseExtensions($container, $inceptionResult->getErrorOutput(), $analysisResult->getProcessedFiles());
 			if (count($internalErrorsTuples) > 0) {
 				foreach ($internalErrorsTuples as [$internalError]) {
 					$inceptionResult->getStdOutput()->writeLineFormatted($internalError->getMessage());
@@ -493,11 +493,12 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 				$analysisResult->getPeakMemoryUsageBytes(),
 				$analysisResult->isResultCacheUsed(),
 				$analysisResult->getChangedProjectExtensionFilesOutsideOfAnalysedPaths(),
+				$analysisResult->getProcessedFiles(),
 			);
 
 			$exitCode = $errorFormatter->formatErrors($analysisResult, $inceptionResult->getStdOutput());
 
-			$this->runDiagnoseExtensions($container, $inceptionResult->getErrorOutput(), $processedFiles);
+			$this->runDiagnoseExtensions($container, $inceptionResult->getErrorOutput(), $analysisResult->getProcessedFiles());
 
 			$errorOutput->writeLineFormatted('⚠️  Result is incomplete because of severe errors. ⚠️');
 			$errorOutput->writeLineFormatted('   Fix these errors first and then re-run PHPStan');
@@ -649,7 +650,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 			}
 		}
 
-		$this->runDiagnoseExtensions($container, $inceptionResult->getErrorOutput(), $processedFiles);
+		$this->runDiagnoseExtensions($container, $inceptionResult->getErrorOutput(), $analysisResult->getProcessedFiles());
 
 		return $inceptionResult->handleReturn(
 			$exitCode,

src/Command/AnalysisResult.php

@@ -24,6 +24,7 @@ final class AnalysisResult
 	 * @param list<string> $warnings
 	 * @param list<CollectedData> $collectedData
 	 * @param array<string, string> $changedProjectExtensionFilesOutsideOfAnalysedPaths
+	 * @param list<string> $processedFiles
 	 */
 	public function __construct(
 		array $fileSpecificErrors,
@@ -37,6 +38,7 @@ public function __construct(
 		private int $peakMemoryUsageBytes,
 		private bool $isResultCacheUsed,
 		private array $changedProjectExtensionFilesOutsideOfAnalysedPaths,
+		private array $processedFiles = [],
 	)
 	{
 		usort(
@@ -148,6 +150,14 @@ public function getChangedProjectExtensionFilesOutsideOfAnalysedPaths(): array
 		return $this->changedProjectExtensionFilesOutsideOfAnalysedPaths;
 	}
 
+	/**
+	 * @return list<string>
+	 */
+	public function getProcessedFiles(): array
+	{
+		return $this->processedFiles;
+	}
+
 	/**
 	 * @api
 	 * @param list<Error> $fileSpecificErrors
@@ -166,6 +176,7 @@ public function withFileSpecificErrors(array $fileSpecificErrors): self
 			$this->peakMemoryUsageBytes,
 			$this->isResultCacheUsed,
 			$this->changedProjectExtensionFilesOutsideOfAnalysedPaths,
+			$this->processedFiles,
 		);
 	}
 

tests/PHPStan/Command/AnalyseApplicationIntegrationTest.php

@@ -78,7 +78,7 @@ private function runPath(string $path, int $expectedStatusCode): string
 			null,
 			CommandHelper::DEFAULT_LEVEL,
 		);
-		[$analysisResult] = $analyserApplication->analyse(
+		$analysisResult = $analyserApplication->analyse(
 			[$path],
 			true,
 			$symfonyOutput,