Add regression test for readonly class property modification via clone()

- New test in tests/PHPStan/Rules/Properties/data/bug-14063.php covering readonly class with clone() property overrides
- Tests AccessPropertiesInAssignRule correctly reports "Assign to protected(set) property" when modifying readonly class properties via clone() from outside the declaring class
- Tests ReadOnlyPropertyAssignRule does not double-report (defers to AccessPropertiesInAssignRule)
- The underlying fix was in BetterReflection 6.70 which correctly sets isProtectedSet() for properties in readonly classes

Closes phpstan/phpstan#14063

Author: VincentLanglet

tests/PHPStan/Rules/Properties/AccessPropertiesInAssignRuleTest.php

@@ -207,6 +207,25 @@ public function testBug13123(): void
 		$this->analyse([__DIR__ . '/data/bug-13123.php'], []);
 	}
 
+	#[RequiresPhp('>= 8.5')]
+	public function testBug14063(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-14063.php'], [
+			[
+				'Assign to protected(set) property Bug14063\Obj::$value.',
+				31,
+			],
+			[
+				'Assign to protected(set) property Bug14063\Obj::$value.',
+				34,
+			],
+			[
+				'Assign to protected(set) property Bug14063\Base::$value.',
+				38,
+			],
+		]);
+	}
+
 	#[RequiresPhp('>= 8.5')]
 	public function testCloneWith(): void
 	{

tests/PHPStan/Rules/Properties/ReadOnlyPropertyAssignRuleTest.php

@@ -180,4 +180,12 @@ public function testCloneWith(): void
 		$this->analyse([__DIR__ . '/data/readonly-property-assign-clone-with.php'], []);
 	}
 
+	#[RequiresPhp('>= 8.5')]
+	public function testBug14063(): void
+	{
+		// readonly class properties modified via clone() from outside the class
+		// are reported by AccessPropertiesInAssignRule, not this rule
+		$this->analyse([__DIR__ . '/data/bug-14063.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Properties/data/bug-14063.php

@@ -0,0 +1,39 @@
+<?php // lint >= 8.5
+
+declare(strict_types = 1);
+
+namespace Bug14063;
+
+final readonly class Obj
+{
+	public function __construct(public string $value) {}
+
+	public function withValue(string $newValue): self
+	{
+		return clone($this, ['value' => $newValue]);
+	}
+}
+
+readonly class Base
+{
+	public function __construct(public string $value) {}
+}
+
+class Child extends Base
+{
+	public function withValue(string $newValue): self
+	{
+		return clone($this, ['value' => $newValue]);
+	}
+}
+
+$obj = new Obj('val');
+$newObj = clone($obj, ['value' => 'newVal']);
+
+function test(Obj $obj): void {
+	clone($obj, ['value' => 'newVal']);
+}
+
+function testBase(Base $base): void {
+	clone($base, ['value' => 'newVal']);
+}