Stop ignoring offsetAccess.invalidOffset (#4871)

VincentLanglet · web-flow · commit ac46a7fd05eb · 2026-02-13T18:08:09.000+01:00
diff --git a/src/Type/Php/VersionCompareFunctionDynamicReturnTypeExtension.php b/src/Type/Php/VersionCompareFunctionDynamicReturnTypeExtension.php
@@ -120,7 +120,7 @@ public function getTypeFromFunctionCall(
 						}
 
 						$value = version_compare($version1String->getValue(), $version2String->getValue(), $operatorValue);
-						$types[$value] = new ConstantBooleanType($value); // @phpstan-ignore offsetAccess.invalidOffset
+						$types[(int) $value] = new ConstantBooleanType($value);
 					}
 				} else {
 					$value = version_compare($version1String->getValue(), $version2String->getValue());

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ public function getTypeFromFunctionCall(`
`120`	`120`	`}`
`121`	`121`
`122`	`122`	`$value = version_compare($version1String->getValue(), $version2String->getValue(), $operatorValue);`
`123`		`- $types[$value] = new ConstantBooleanType($value); // @phpstan-ignore offsetAccess.invalidOffset`
	`123`	`+ $types[(int) $value] = new ConstantBooleanType($value);`
`124`	`124`	`}`
`125`	`125`	`} else {`
`126`	`126`	`$value = version_compare($version1String->getValue(), $version2String->getValue());`