Fix false positive dead catch for ReflectionMethod::invoke/invokeArgs

- Added ReflectionMethodInvokeMethodThrowTypeExtension to declare that
  ReflectionMethod::invoke() and invokeArgs() can throw any Throwable,
  since they execute arbitrary user code
- New regression test in tests/PHPStan/Rules/Exceptions/data/bug-7719.php
- The root cause was that without a DynamicMethodThrowTypeExtension,
  PHPStan only considered ReflectionException (from stubs) as the throw
  type, causing any non-ReflectionException catch to be flagged as dead

Author: phpstan-bot

src/Type/Php/ReflectionMethodInvokeMethodThrowTypeExtension.php

@@ -0,0 +1,31 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Type\Php;
+
+use PhpParser\Node\Expr\MethodCall;
+use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredService;
+use PHPStan\Reflection\MethodReflection;
+use PHPStan\Type\DynamicMethodThrowTypeExtension;
+use PHPStan\Type\ObjectType;
+use PHPStan\Type\Type;
+use ReflectionMethod;
+use Throwable;
+use function in_array;
+
+#[AutowiredService]
+final class ReflectionMethodInvokeMethodThrowTypeExtension implements DynamicMethodThrowTypeExtension
+{
+
+	public function isMethodSupported(MethodReflection $methodReflection): bool
+	{
+		return in_array($methodReflection->getName(), ['invoke', 'invokeArgs'], true)
+			&& $methodReflection->getDeclaringClass()->getName() === ReflectionMethod::class;
+	}
+
+	public function getThrowTypeFromMethodCall(MethodReflection $methodReflection, MethodCall $methodCall, Scope $scope): Type
+	{
+		return new ObjectType(Throwable::class);
+	}
+
+}

tests/PHPStan/Rules/Exceptions/CatchWithUnthrownExceptionRuleTest.php

@@ -643,4 +643,9 @@ public function testPropertyHooks(): void
 		]);
 	}
 
+	public function testBug7719(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-7719.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Exceptions/data/bug-7719.php

@@ -0,0 +1,34 @@
+<?php declare(strict_types = 1);
+
+namespace Bug7719;
+
+class Endpoint {
+	public function run(int $id): int {
+		return $id;
+	}
+}
+
+class HelloWorld
+{
+	public function sayHello(Endpoint $endpoint, string $methodName): void
+	{
+		try {
+			$methodResponse = (new \ReflectionMethod($endpoint, $methodName))->invokeArgs($endpoint, ['id' => 2]);
+		} catch (\RuntimeException $e) {
+			echo $e->getMessage();
+			die;
+		}
+		var_dump($methodResponse);
+	}
+
+	public function sayHelloInvoke(Endpoint $endpoint, string $methodName): void
+	{
+		try {
+			$methodResponse = (new \ReflectionMethod($endpoint, $methodName))->invoke($endpoint, 2);
+		} catch (\RuntimeException $e) {
+			echo $e->getMessage();
+			die;
+		}
+		var_dump($methodResponse);
+	}
+}