More pair-wise intersect

Author: ondrejmirtes

src/Reflection/Type/IntersectionTypeMethodReflection.php

@@ -94,9 +94,18 @@ public function getVariants(): array
 			}
 		}
 
-		$returnType = TypeCombinator::intersect(...$returnTypes);
-		$phpDocReturnType = TypeCombinator::intersect(...$phpDocReturnTypes);
-		$nativeReturnType = TypeCombinator::intersect(...$nativeReturnTypes);
+		$returnType = $returnTypes[0];
+		for ($i = 1, $count = count($returnTypes); $i < $count; $i++) {
+			$returnType = TypeCombinator::intersect($returnType, $returnTypes[$i]);
+		}
+		$phpDocReturnType = $phpDocReturnTypes[0];
+		for ($i = 1, $count = count($phpDocReturnTypes); $i < $count; $i++) {
+			$phpDocReturnType = TypeCombinator::intersect($phpDocReturnType, $phpDocReturnTypes[$i]);
+		}
+		$nativeReturnType = $nativeReturnTypes[0];
+		for ($i = 1, $count = count($nativeReturnTypes); $i < $count; $i++) {
+			$nativeReturnType = TypeCombinator::intersect($nativeReturnType, $nativeReturnTypes[$i]);
+		}
 		return array_map(static fn (ExtendedParametersAcceptor $acceptor): ExtendedParametersAcceptor => new ExtendedFunctionVariant(
 			$acceptor->getTemplateTypeMap(),
 			$acceptor->getResolvedTemplateTypeMap(),
@@ -188,7 +197,11 @@ public function getThrowType(): ?Type
 			return null;
 		}
 
-		return TypeCombinator::intersect(...$types);
+		$result = $types[0];
+		for ($i = 1, $count = count($types); $i < $count; $i++) {
+			$result = TypeCombinator::intersect($result, $types[$i]);
+		}
+		return $result;
 	}
 
 	public function hasSideEffects(): TrinaryLogic

src/Reflection/Type/IntersectionTypePropertyReflection.php

@@ -9,7 +9,6 @@
 use PHPStan\TrinaryLogic;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeCombinator;
-use function array_map;
 use function count;
 use function implode;
 
@@ -92,7 +91,7 @@ public function hasPhpDocType(): bool
 
 	public function getPhpDocType(): Type
 	{
-		return TypeCombinator::intersect(...array_map(static fn (ExtendedPropertyReflection $property): Type => $property->getPhpDocType(), $this->properties));
+		return $this->pairwiseIntersect(static fn (ExtendedPropertyReflection $property): Type => $property->getPhpDocType());
 	}
 
 	public function hasNativeType(): bool
@@ -102,17 +101,29 @@ public function hasNativeType(): bool
 
 	public function getNativeType(): Type
 	{
-		return TypeCombinator::intersect(...array_map(static fn (ExtendedPropertyReflection $property): Type => $property->getNativeType(), $this->properties));
+		return $this->pairwiseIntersect(static fn (ExtendedPropertyReflection $property): Type => $property->getNativeType());
 	}
 
 	public function getReadableType(): Type
 	{
-		return TypeCombinator::intersect(...array_map(static fn (ExtendedPropertyReflection $property): Type => $property->getReadableType(), $this->properties));
+		return $this->pairwiseIntersect(static fn (ExtendedPropertyReflection $property): Type => $property->getReadableType());
 	}
 
 	public function getWritableType(): Type
 	{
-		return TypeCombinator::intersect(...array_map(static fn (ExtendedPropertyReflection $property): Type => $property->getWritableType(), $this->properties));
+		return $this->pairwiseIntersect(static fn (ExtendedPropertyReflection $property): Type => $property->getWritableType());
+	}
+
+	/**
+	 * @param callable(ExtendedPropertyReflection): Type $getType
+	 */
+	private function pairwiseIntersect(callable $getType): Type
+	{
+		$result = $getType($this->properties[0]);
+		for ($i = 1, $count = count($this->properties); $i < $count; $i++) {
+			$result = TypeCombinator::intersect($result, $getType($this->properties[$i]));
+		}
+		return $result;
 	}
 
 	public function canChangeTypeAfterAssignment(): bool

src/Type/IntersectionType.php

@@ -1378,7 +1378,11 @@ public function traverse(callable $cb): Type
 		}
 
 		if ($changed) {
-			return TypeCombinator::intersect(...$types);
+			$result = $types[0];
+			for ($i = 1, $count = count($types); $i < $count; $i++) {
+				$result = TypeCombinator::intersect($result, $types[$i]);
+			}
+			return $result;
 		}
 
 		return $this;
@@ -1415,7 +1419,11 @@ public function traverseSimultaneously(Type $right, callable $cb): Type
 				return $this;
 			}
 
-			return TypeCombinator::intersect(...$newTypes);
+			$result = $newTypes[0];
+			for ($i = 1, $count = count($newTypes); $i < $count; $i++) {
+				$result = TypeCombinator::intersect($result, $newTypes[$i]);
+			}
+			return $result;
 		}
 
 		return $this;
@@ -1481,7 +1489,11 @@ private function intersectResults(
 	private function intersectTypes(callable $getType): Type
 	{
 		$operands = array_map($getType, $this->types);
-		return TypeCombinator::intersect(...$operands);
+		$result = $operands[0];
+		for ($i = 1, $count = count($operands); $i < $count; $i++) {
+			$result = TypeCombinator::intersect($result, $operands[$i]);
+		}
+		return $result;
 	}
 
 	public function toPhpDocNode(): TypeNode

src/Type/TypeCombinator.php

@@ -1668,7 +1668,11 @@ private static function mergeIntersectionsForUnion(IntersectionType $a, Intersec
 			return null;
 		}
 
-		return self::intersect(...$mergedTypes);
+		$result = $mergedTypes[0];
+		for ($i = 1, $count = count($mergedTypes); $i < $count; $i++) {
+			$result = self::intersect($result, $mergedTypes[$i]);
+		}
+		return $result;
 	}
 
 	public static function removeFalsey(Type $type): Type