Fix workflows

Author: ondrejmirtes

.github/workflows/backward-compatibility.yml

@@ -51,4 +51,4 @@ jobs:
           composer global require --dev ondrejmirtes/backward-compatibility-check:^7.3.0.1
 
       - name: "Check"
-        run: "$(composer global config bin-dir --absolute)/roave-backward-compatibility-check"
+        run: '"$(composer global config bin-dir --absolute)"/roave-backward-compatibility-check'

.github/workflows/issue-bot.yml

@@ -68,7 +68,7 @@ jobs:
         id: shards
         working-directory: "issue-bot"
         run: |
-          echo "shards=$(jq -c '{include: [range(length) | {shard: .}]}' matrix.json)" >> $GITHUB_OUTPUT
+          echo "shards=$(jq -c '{include: [range(length) | {shard: .}]}' matrix.json)" >> "$GITHUB_OUTPUT"
 
       - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
         with:
@@ -210,7 +210,7 @@ jobs:
           ./console.php evaluate > tmp/step-summary.md
           exit_code="$?"
 
-          cat tmp/step-summary.md >> $GITHUB_STEP_SUMMARY
+          cat tmp/step-summary.md >> "$GITHUB_STEP_SUMMARY"
 
           if [[ "$exit_code" == "2" ]]; then
             echo "::notice file=.github/workflows/issue-bot.yml,line=3 ::Issue bot detected open issues which are affected by this pull request - see https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID"
@@ -235,7 +235,7 @@ jobs:
           PHPSTAN_SRC_COMMIT_AFTER: ${{ github.event.after }}
         run: |
           set +e
-          ./console.php evaluate --post-comments >> $GITHUB_STEP_SUMMARY
+          ./console.php evaluate --post-comments >> "$GITHUB_STEP_SUMMARY"
           exit_code="$?"
 
           # its fine when issue-bot found affected issues

.github/workflows/phar.yml

@@ -112,7 +112,7 @@ jobs:
 
       - name: "Save checksum"
         id: "checksum"
-        run: echo "md5=$(md5sum tmp/phpstan.phar | cut -d' ' -f1)" >> $GITHUB_OUTPUT
+        run: echo "md5=$(md5sum tmp/phpstan.phar | cut -d' ' -f1)" >> "$GITHUB_OUTPUT"
 
       - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
         with:
@@ -231,7 +231,7 @@ jobs:
 
       - name: "Save old checksum"
         id: "old_checksum"
-        run: echo "md5=$(md5sum phpstan.phar | cut -d' ' -f1)" >> $GITHUB_OUTPUT
+        run: echo "md5=$(md5sum phpstan.phar | cut -d' ' -f1)" >> "$GITHUB_OUTPUT"
 
       - name: "Assert checksum"
         run: |
@@ -330,7 +330,7 @@ jobs:
       - name: "Get previous pushed dist commit"
         id: previous-commit
         working-directory: phpstan-dist
-        run: echo "sha=$(sed -n '2p' .phar-checksum)" >> $GITHUB_OUTPUT
+        run: echo "sha=$(sed -n '2p' .phar-checksum)" >> "$GITHUB_OUTPUT"
 
       - name: "Checkout phpstan-src"
         uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
@@ -342,24 +342,24 @@ jobs:
         id: git-log
         working-directory: phpstan-src
         run: |
-          echo "log<<MESSAGE" >> $GITHUB_OUTPUT
-          echo "$(git log ${{ steps.previous-commit.outputs.sha }}..${{ github.event.after }} --reverse --pretty='https://github.com/phpstan/phpstan-src/commit/%H %s')" >> $GITHUB_OUTPUT
-          echo 'MESSAGE' >> $GITHUB_OUTPUT
+          echo "log<<MESSAGE" >> "$GITHUB_OUTPUT"
+          git log ${{ steps.previous-commit.outputs.sha }}..${{ github.event.after }} --reverse --pretty='https://github.com/phpstan/phpstan-src/commit/%H %s' >> "$GITHUB_OUTPUT"
+          echo 'MESSAGE' >> "$GITHUB_OUTPUT"
 
       - name: "Get short phpstan-src SHA"
         id: short-src-sha
         working-directory: phpstan-src
-        run: echo "sha=$(git rev-parse --short=7 HEAD)" >> $GITHUB_OUTPUT
+        run: echo "sha=$(git rev-parse --short=7 HEAD)" >> "$GITHUB_OUTPUT"
 
       - name: "Check PHAR checksum"
         id: checksum-difference
         working-directory: phpstan-dist
         run: |
-          checksum=${{needs.compiler-tests.outputs.checksum}}
+          checksum="${{needs.compiler-tests.outputs.checksum}}"
           if [[ $(head -n 1 .phar-checksum) != "$checksum" ]]; then
-            echo "result=different" >> $GITHUB_OUTPUT
+            echo "result=different" >> "$GITHUB_OUTPUT"
           else
-            echo "result=same" >> $GITHUB_OUTPUT
+            echo "result=same" >> "$GITHUB_OUTPUT"
           fi
 
       - name: "Download phpstan.phar"

.github/workflows/static-analysis.yml

@@ -185,6 +185,6 @@ jobs:
 
       - name: "Generate baseline"
         run: |
-          > phpstan-baseline.neon && \
+          true > phpstan-baseline.neon && \
           make phpstan-generate-baseline-php && \
           make phpstan-result-cache

.github/workflows/tests.yml

@@ -171,7 +171,7 @@ jobs:
       - uses: "ramsey/composer-install@3cf229dc2919194e9e36783941438d17239e8520" # v3
 
       - id: set-matrix
-        run: echo "matrix=$(php .github/workflows/tests-levels-matrix.php)" >> $GITHUB_OUTPUT
+        run: echo "matrix=$(php .github/workflows/tests-levels-matrix.php)" >> "$GITHUB_OUTPUT"
 
     outputs:
       matrix: ${{ steps.set-matrix.outputs.matrix }}
@@ -325,12 +325,12 @@ jobs:
             --source-directory='build/PHPStan/Build' \
             --timeout=500 \
           > infection.json5
-          cat infection.json5 | jq
+          jq < infection.json5
 
       - name: "Determine default branch"
         id: default-branch
         run: |
-          echo "name=$(git remote show origin | sed -n '/HEAD branch/s/.*: //p')" >> $GITHUB_OUTPUT
+          echo "name=$(git remote show origin | sed -n '/HEAD branch/s/.*: //p')" >> "$GITHUB_OUTPUT"
 
       - name: "Restore result cache"
         uses: actions/cache/restore@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0

.github/workflows/update-phpstorm-stubs.yml

@@ -39,7 +39,7 @@ jobs:
           path: "phpstorm-stubs"
           repository: "jetbrains/phpstorm-stubs"
       - name: "Update stubs"
-        run: "composer require jetbrains/phpstorm-stubs:dev-master#$(git -C phpstorm-stubs rev-parse HEAD)"
+        run: "composer require \"jetbrains/phpstorm-stubs:dev-master#$(git -C phpstorm-stubs rev-parse HEAD)\""
       - name: "Remove stubs repo"
         run: "rm -r phpstorm-stubs"
       - name: "Update function metadata"