Add regression tests for #13663, #10349, #8648

Closes phpstan/phpstan#13663
Closes phpstan/phpstan#10349
Closes phpstan/phpstan#8648

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: ondrejmirtes

tests/PHPStan/Analyser/nsrt/bug-13663.php

@@ -0,0 +1,30 @@
+<?php declare(strict_types = 1);
+
+namespace Bug13663;
+
+use function PHPStan\Testing\assertType;
+
+/**
+ * @param array<int, array{foo: array<int, mixed>, count: int}> $usageDetailMap
+ */
+function test(array $usageDetailMap): void {
+	assertType('array<int, array{foo: array<int, mixed>, count: int}>', $usageDetailMap);
+
+	foreach ([1,2] as $projectNumberId) {
+		assertType('array<int, array{foo: array<int, mixed>, count: int}>', $usageDetailMap);
+		if (!array_key_exists($projectNumberId, $usageDetailMap)) {
+			$usageDetailMap[$projectNumberId] = [
+			  'foo'   => [],
+			  'count' => 0,
+			];
+		}
+
+		$usageDetailMap[$projectNumberId]['count'] = $usageDetailMap[$projectNumberId]['count'] + 1;
+
+		foreach ($usageDetailMap as $existingProjectNumberId => $value) {
+			$usageDetailMap[$existingProjectNumberId]['foo'][] = 'foo';
+		}
+
+		$usageDetailMap[$projectNumberId]['count'] = $usageDetailMap[$projectNumberId]['count'] + 1;
+	}
+}

tests/PHPStan/Rules/Arrays/OffsetAccessAssignmentRuleTest.php

@@ -201,4 +201,10 @@ public function testBug11572(): void
 		]);
 	}
 
+	public function testBug8648(): void
+	{
+		$this->checkUnionTypes = true;
+		$this->analyse([__DIR__ . '/data/bug-8648.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Arrays/data/bug-8648.php

@@ -0,0 +1,34 @@
+<?php declare(strict_types = 1);
+
+namespace Bug8648;
+
+class Data
+{
+}
+
+class HelloWorld
+{
+	/**
+	 * @var mixed[]
+	 */
+	private $data;
+
+	/**
+	 * @return mixed[]
+	 */
+    public function processData(): array
+    {
+        $this->data['foo'] = [
+            'id' => 'some_id',
+        ];
+
+        foreach (['a' => 'aa', 'b' => 'bb', 'c' => 'cc'] as $type => $value) {
+            $this->data['foo']['bar'][] = [
+                'type' => $type,
+                'value' => $value,
+            ];
+        }
+
+		return $this->data;
+    }
+}

tests/PHPStan/Rules/Operators/InvalidBinaryOperationRuleTest.php

@@ -835,4 +835,22 @@ public function testBug14080(): void
 		$this->analyse([__DIR__ . '/data/bug-14080.php'], []);
 	}
 
+	public function testBug10349(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-10349.php'], [
+			[
+				'Binary operation "+=" between bool|float|int|string and int results in an error.',
+				36,
+			],
+			[
+				'Binary operation "+=" between bool|float|int|string and int results in an error.',
+				63,
+			],
+			[
+				'Binary operation "+=" between bool|float|int|string and int results in an error.',
+				82,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Operators/data/bug-10349.php

@@ -0,0 +1,91 @@
+<?php
+
+namespace Bug10349;
+
+class Foo
+{
+    /** @return void */
+    public function testSomething()
+    {
+        $expected    = [];
+        $expected[0] = [
+            'number-1'      => 3, // Offset
+            'name'          => '$a',
+            'number-2'      => 3, // Offset
+            'number-3'      => 3, // Offset
+            'has_something' => false,
+        ];
+
+        $this->issue_1_A(10, $expected);
+        $this->issue_1_B(10, $expected);
+        $this->issue_2(10, $expected);
+    }
+
+    /**
+     * Test helper.
+     *
+     * @param int                               $ptr
+     * @param array<int, array<string, scalar>> $expected
+     *
+     * @return array<int, array<string, scalar>>
+     */
+    private function issue_1_A($ptr, $expected)
+    {
+        foreach ($expected as $key => $param) {
+            if ($param['number-1'] !== false) {
+                $expected[$key]['number-1'] += $ptr;
+            }
+
+            if ($param['number-2'] !== false) {
+                $expected[$key]['number-2'] += $ptr;
+            }
+        }
+
+        return $expected;
+    }
+
+    /**
+     * Test helper.
+     *
+     * @param int                               $ptr
+     * @param array<int, array<string, scalar>> $expected
+     *
+     * @return array<int, array<string, scalar>>
+     */
+    private function issue_1_B($ptr, $expected)
+    {
+        foreach ($expected as $key => $param) {
+            if (is_int($expected[$key]['number-1'])) {
+                $expected[$key]['number-1'] += $ptr;
+            }
+
+            if ($param['number-2'] !== false) {
+                $expected[$key]['number-2'] += $ptr;
+            }
+        }
+
+        return $expected;
+    }
+
+    /**
+     * Test helper.
+     *
+     * @param int                               $ptr
+     * @param array<int, array<string, scalar>> $expected
+     *
+     * @return array<int, array<string, scalar>>
+     */
+    private function issue_2($ptr, $expected)
+    {
+        foreach ($expected as $key => $param) {
+            if (is_int($param['number-1'])) {
+                $expected[$key]['number-1'] += $ptr;
+            }
+            if (is_int($param['number-2'])) {
+                $expected[$key]['number-2'] += $ptr;
+            }
+        }
+
+        return $expected;
+    }
+}