Simplify cast unwrapping in comparisons to always unwrap

The previous approach only unwrapped cast expressions when the cast
type equaled the inner type (redundant cast). This failed for cases
where the variable had a union type with non-integer parts (e.g.
int|numeric-string after ctype_digit), because the cast was not
redundant and the narrowing was never applied.

The narrowing type (e.g. mixed~(0.0|int<min, 2021>|false|null))
already correctly preserves non-integer parts of the type through
intersection, so unconditional unwrapping produces correct results
for all cases.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: 2 people

src/Analyser/TypeSpecifier.php

@@ -494,19 +494,11 @@ public function specifyTypesInCondition(
 
 			$leftExpr = $expr->left;
 			if ($leftExpr instanceof Expr\Cast) {
-				$castedType = $scope->getType($leftExpr);
-				$innerType = $scope->getType($leftExpr->expr);
-				if ($castedType->equals($innerType)) {
-					$leftExpr = $leftExpr->expr;
-				}
+				$leftExpr = $leftExpr->expr;
 			}
 			$rightExpr = $expr->right;
 			if ($rightExpr instanceof Expr\Cast) {
-				$castedType = $scope->getType($rightExpr);
-				$innerType = $scope->getType($rightExpr->expr);
-				if ($castedType->equals($innerType)) {
-					$rightExpr = $rightExpr->expr;
-				}
+				$rightExpr = $rightExpr->expr;
 			}
 
 			if ($context->true()) {