Faster MutatingScope->getNodeKey() (#5014)

Author: staabm

src/Analyser/MutatingScope.php

@@ -917,8 +917,12 @@ public function getScopeNativeType(Expr $expr): Type
 
 	private function getNodeKey(Expr $node): string
 	{
-		$key = $this->exprPrinter->printExpr($node);
+		// perf optimize for the most common path
+		if ($node instanceof Variable && !$node->name instanceof Expr) {
+			return '$' . $node->name;
+		}
 
+		$key = $this->exprPrinter->printExpr($node);
 		$attributes = $node->getAttributes();
 		if (
 			$node instanceof Node\FunctionLike

src/Node/Printer/ExprPrinter.php

@@ -20,6 +20,11 @@ public function __construct(private Printer $printer)
 
 	public function printExpr(Expr $expr): string
 	{
+		// perf optimize for the most common path
+		if ($expr instanceof Expr\Variable && !$expr->name instanceof Expr) {
+			return '$' . $expr->name;
+		}
+
 		/** @var string|null $exprString */
 		$exprString = $expr->getAttribute(self::ATTRIBUTE_CACHE_KEY);
 		if ($exprString === null) {