Capture current ConstantArrayType inconsistencies related to sealedness

Author: ondrejmirtes

tests/PHPStan/Type/Constant/ConstantArrayTypeTest.php

@@ -408,6 +408,32 @@ public static function dataAccepts(): iterable
 			]),
 			TrinaryLogic::createMaybe(),
 		];
+
+		yield [
+			new ConstantArrayType([], []),
+			new ConstantArrayType([], []),
+			TrinaryLogic::createYes(),
+		];
+
+		// empty array (with unknown sealedness) does not accept extra keys
+		yield [
+			new ConstantArrayType([], []),
+			new ConstantArrayType([new ConstantStringType('a')], [new StringType()]),
+			TrinaryLogic::createNo(),
+		];
+
+		// non-empty array (with unknown sealedness) accepts extra keys
+		yield [
+			new ConstantArrayType([new ConstantStringType('a')], [new StringType()]),
+			new ConstantArrayType([
+				new ConstantStringType('a'),
+				new ConstantStringType('b'),
+			], [
+				new StringType(),
+				new IntegerType(),
+			]),
+			TrinaryLogic::createYes(),
+		];
 	}
 
 	#[DataProvider('dataAccepts')]
@@ -690,6 +716,26 @@ public static function dataIsSuperTypeOf(): iterable
 			new ArrayType(new StringType(), new MixedType()),
 			TrinaryLogic::createNo(),
 		];
+
+		// empty array (with unknown sealedness) does not accept extra keys
+		yield [
+			new ConstantArrayType([], []),
+			new ConstantArrayType([new ConstantStringType('a')], [new StringType()]),
+			TrinaryLogic::createNo(),
+		];
+
+		// non-empty array (with unknown sealedness) accepts extra keys
+		yield [
+			new ConstantArrayType([new ConstantStringType('a')], [new StringType()]),
+			new ConstantArrayType([
+				new ConstantStringType('a'),
+				new ConstantStringType('b'),
+			], [
+				new StringType(),
+				new IntegerType(),
+			]),
+			TrinaryLogic::createYes(),
+		];
 	}
 
 	#[DataProvider('dataIsSuperTypeOf')]