fix

Author: staabm

src/Reflection/BetterReflection/SourceLocator/FileCachedSourceLocator.php

@@ -16,6 +16,7 @@
 use PHPStan\Internal\ComposerHelper;
 use PHPStan\Php\PhpVersion;
 use PHPStan\Reflection\ConstantNameHelper;
+use PHPStan\ShouldNotHappenException;
 use function array_key_exists;
 use function register_shutdown_function;
 use function sprintf;
@@ -24,11 +25,14 @@
 final class FileCachedSourceLocator implements SourceLocator
 {
 
-	/** @var array{classes: array<string, ReflectionClass>, functions: array<string, ReflectionFunction>, constants: array<string, ReflectionConstant>}|null */
+	/** @var array{classes: array<string, ?Reflection>, functions: array<string, ?Reflection>, constants: array<string, ?Reflection>}|null */
 	private ?array $cachedSymbols = null;
 
 	private bool $storeOnShutdown = false;
 
+	/**
+	 * @param non-empty-string $cacheKey
+	 */
 	public function __construct(
 		private SourceLocator $locator,
 		private Cache $cache,
@@ -47,7 +51,7 @@ public function locateIdentifier(Reflector $reflector, Identifier $identifier):
 			$className = strtolower($identifier->getName());
 
 			if (!array_key_exists($className, $this->cachedSymbols['classes'])) {
-				$this->cachedSymbols['classes'][$className] ??= $this->locator->locateIdentifier($reflector, $identifier);
+				$this->cachedSymbols['classes'][$className] = $this->locator->locateIdentifier($reflector, $identifier);
 				$this->storeOnShutdown();
 			}
 			return $this->cachedSymbols['classes'][$className];
@@ -56,7 +60,7 @@ public function locateIdentifier(Reflector $reflector, Identifier $identifier):
 			$className = strtolower($identifier->getName());
 
 			if (!array_key_exists($className, $this->cachedSymbols['functions'])) {
-				$this->cachedSymbols['functions'][$className] ??= $this->locator->locateIdentifier($reflector, $identifier);
+				$this->cachedSymbols['functions'][$className] = $this->locator->locateIdentifier($reflector, $identifier);
 				$this->storeOnShutdown();
 			}
 			return $this->cachedSymbols['functions'][$className];
@@ -65,7 +69,7 @@ public function locateIdentifier(Reflector $reflector, Identifier $identifier):
 			$constantName = ConstantNameHelper::normalize($identifier->getName());
 
 			if (!array_key_exists($constantName, $this->cachedSymbols['constants'])) {
-				$this->cachedSymbols['constants'][$constantName] ??= $this->locator->locateIdentifier($reflector, $identifier);
+				$this->cachedSymbols['constants'][$constantName] = $this->locator->locateIdentifier($reflector, $identifier);
 				$this->storeOnShutdown();
 			}
 			return $this->cachedSymbols['constants'][$constantName];
@@ -80,6 +84,7 @@ public function locateIdentifiersByType(Reflector $reflector, IdentifierType $id
 		return $this->locator->locateIdentifiersByType($reflector, $identifierType);
 	}
 
+	/** @return non-empty-string */
 	private function getVariableCacheKey(): string
 	{
 		return sprintf('v2-%s-%s', ComposerHelper::getBetterReflectionVersion(), $this->phpVersion->getVersionString());
@@ -95,7 +100,7 @@ private function storeOnShutdown(): void
 		register_shutdown_function([$this, 'storeCache']);
 	}
 
-	/** @return array{classes: array<string, ReflectionClass>, functions: array<string, ReflectionFunction>, constants: array<string, ReflectionConstant>} */
+	/** @return array{classes: array<string, ReflectionClass|null>, functions: array<string, ReflectionFunction|null>, constants: array<string, ReflectionConstant|null>} */
 	private function loadCache(Reflector $reflector): array
 	{
 		$variableCacheKey = $this->getVariableCacheKey();
@@ -156,6 +161,15 @@ private function storeCache(): void
 					$exported[$type][$name] = $reflection;
 					continue;
 				}
+
+				if (
+					!$reflection instanceof ReflectionClass
+					&& !$reflection instanceof ReflectionFunction
+					&& !$reflection instanceof ReflectionConstant
+				) {
+					throw new ShouldNotHappenException();
+				}
+
 				$exported[$type][$name] = $reflection->exportToCache();
 			}
 		}