Skip to content

Commit c04ed10

Browse files
phpstan-botclaude
andcommitted
Simplify nested condition in ParametersAcceptorSelector
Invert the condition to reduce nesting and use $typesCount variable instead of redundant count($types) call. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 949ada0 commit c04ed10

1 file changed

Lines changed: 12 additions & 14 deletions

File tree

src/Reflection/ParametersAcceptorSelector.php

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -650,21 +650,19 @@ public static function selectFromTypes(
650650
$isSuperType = TrinaryLogic::createYes();
651651
$acceptableAcceptor = GenericParametersAcceptorResolver::resolve($types, $acceptableAcceptor);
652652
foreach ($acceptableAcceptor->getParameters() as $i => $parameter) {
653-
if (!isset($types[$i])) {
654-
if ($hasNamedTypes && isset($types[$parameter->getName()])) {
655-
$type = $types[$parameter->getName()];
656-
} elseif ($hasNamedTypes && $parameter->isOptional()) {
657-
continue;
658-
} elseif ($hasNamedTypes) {
659-
$isSuperType = TrinaryLogic::createNo();
660-
break;
661-
} elseif ($unpack && count($types) > 0) {
662-
$type = $types[array_key_last($types)];
663-
} else {
664-
break;
665-
}
666-
} else {
653+
if (isset($types[$i])) {
667654
$type = $types[$i];
655+
} elseif ($hasNamedTypes && isset($types[$parameter->getName()])) {
656+
$type = $types[$parameter->getName()];
657+
} elseif ($hasNamedTypes && $parameter->isOptional()) {
658+
continue;
659+
} elseif ($hasNamedTypes) {
660+
$isSuperType = TrinaryLogic::createNo();
661+
break;
662+
} elseif ($unpack && count($types) > 0) {
663+
$type = $types[array_key_last($types)];
664+
} else {
665+
break;
668666
}
669667

670668
if ($parameter->getType() instanceof MixedType) {

0 commit comments

Comments
 (0)