refactor

Author: staabm

src/Type/AcceptsResult.php

@@ -152,4 +152,25 @@ public static function maxMin(self ...$operands): self
 		return new self(TrinaryLogic::maxMin(...$results), array_values(array_unique($reasons)));
 	}
 
+	/**
+	 * @template T
+	 * @param T[] $objects
+	 * @param callable(T): self $callback
+	 */
+	public static function lazyMaxMin(
+		array $objects,
+		callable $callback,
+	): self
+	{
+		$results = [];
+		foreach ($objects as $object) {
+			$isAcceptedBy = $callback($object);
+			if ($isAcceptedBy->result->yes()) {
+				return $isAcceptedBy;
+			}
+			$results[] = $isAcceptedBy;
+		}
+		return self::maxMin(...$results);
+	}
+
 }

src/Type/IntersectionType.php

@@ -266,15 +266,10 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult
 			return $otherType->isSuperTypeOf($this);
 		}
 
-		$results = [];
-		foreach ($this->types as $innerType) {
-			$isSuperTypeOf = $otherType->isSuperTypeOf($innerType);
-			if ($isSuperTypeOf->yes()) {
-				return IsSuperTypeOfResult::createYes();
-			}
-			$results[] = $isSuperTypeOf;
-		}
-		$result = IsSuperTypeOfResult::maxMin(...$results);
+		$result = IsSuperTypeOfResult::lazyMaxMin(
+			$this->types,
+			static fn (Type $innerType) => $otherType->isSuperTypeOf($innerType),
+		);
 
 		if (
 			!$result->no()
@@ -289,15 +284,10 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult
 
 	public function isAcceptedBy(Type $acceptingType, bool $strictTypes): AcceptsResult
 	{
-		$results = [];
-		foreach ($this->types as $innerType) {
-			$isAcceptedBy = $acceptingType->accepts($innerType, $strictTypes);
-			if ($isAcceptedBy->yes()) {
-				return AcceptsResult::createYes();
-			}
-			$results[] = $isAcceptedBy;
-		}
-		$result = AcceptsResult::maxMin(...$results);
+		$result = AcceptsResult::lazyMaxMin(
+			$this->types,
+			static fn (Type $innerType) => $acceptingType->accepts($innerType, $strictTypes),
+		);
 
 		if ($this->isOversizedArray()->yes()) {
 			if (!$result->no()) {

src/Type/IsSuperTypeOfResult.php

@@ -185,6 +185,27 @@ public static function maxMin(self ...$operands): self
 		return new self(TrinaryLogic::maxMin(...$results), array_values(array_unique($reasons)));
 	}
 
+	/**
+	 * @template T
+	 * @param T[] $objects
+	 * @param callable(T): self $callback
+	 */
+	public static function lazyMaxMin(
+		array $objects,
+		callable $callback,
+	): self
+	{
+		$results = [];
+		foreach ($objects as $object) {
+			$isSuperTypeOf = $callback($object);
+			if ($isSuperTypeOf->result->yes()) {
+				return $isSuperTypeOf;
+			}
+			$results[] = $isSuperTypeOf;
+		}
+		return self::maxMin(...$results);
+	}
+
 	public function negate(): self
 	{
 		return new self($this->result->negate(), $this->reasons);