Commit c36922b
fix(type-system): sealed class-string match exhaustiveness for ::class comparisons
GenericClassStringType::tryRemove() did not handle @phpstan-sealed hierarchies,
so match expressions on $foo::class falsely reported unhandled remaining values
even when all allowed subtypes were covered. Delegates to TypeCombinator::remove()
which already handles sealed subtraction via ObjectType::changeSubtractedType().
Closes phpstan/phpstan#12241
Co-Authored-By: Ondrej Mirtes <ondrej@mirtes.cz>1 parent 43c1a1b commit c36922b
File tree
3 files changed
+38
-0
lines changed- src/Type/Generic
- tests/PHPStan/Rules/Comparison
- data
3 files changed
+38
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
219 | 219 | | |
220 | 220 | | |
221 | 221 | | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
222 | 234 | | |
223 | 235 | | |
224 | 236 | | |
| |||
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
447 | 447 | | |
448 | 448 | | |
449 | 449 | | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
450 | 456 | | |
451 | 457 | | |
452 | 458 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
0 commit comments