Fix phpstan/phpstan#14320: False positive contravariant parameter with nested trait

- Skip traits that inherited an abstract method from a sub-trait in ParentMethodHelper::collectParentMethods
- The actual declaring trait is still checked separately in the same loop
- New regression test in tests/PHPStan/Rules/Methods/data/bug-14320.php

Author: phpstan-bot

src/Rules/Methods/ParentMethodHelper.php

@@ -53,6 +53,12 @@ public function collectParentMethods(string $methodName, ClassReflection $class)
 				continue;
 			}
 
+			// Skip traits that inherited the method from a sub-trait
+			// The actual declaring trait will be processed separately
+			if ($methodReflection->getBetterReflection()->getDeclaringClass()->getName() !== $trait->getName()) {
+				continue;
+			}
+
 			$declaringTrait = $trait->getNativeMethod($methodName)->getDeclaringClass();
 			$parentMethods[] = [
 				$this->phpClassReflectionExtension->createUserlandMethodReflection(

tests/PHPStan/Rules/Methods/MethodSignatureRuleTest.php

@@ -558,4 +558,11 @@ public function testBug12073(): void
 		$this->analyse([__DIR__ . '/data/bug-12073.php'], []);
 	}
 
+	public function testBug14320(): void
+	{
+		$this->reportMaybes = true;
+		$this->reportStatic = true;
+		$this->analyse([__DIR__ . '/data/bug-14320.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Methods/data/bug-14320.php

@@ -0,0 +1,33 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14320;
+
+trait MyTrait
+{
+	/**
+	* @param array<string, mixed> $data
+	* @return array<string, mixed>
+	*/
+	abstract protected function myFunction(array $data): array;
+}
+
+trait MyFirstTrait
+{
+	use MyTrait;
+}
+
+abstract class MyAbstractClass
+{
+	use MyFirstTrait;
+
+	/**
+	* @param array<string, mixed> $data
+	* @return array<string, mixed>
+	*/
+	protected function myFunction(array $data): array
+	{
+		return [
+			'hello' => 'bug',
+		];
+	}
+}