Use isSuperTypeOf as guard in IntersectionType::isAcceptedBy() instead of special-casing callable&array

Replace the callable&array-specific narrowing logic with a general
approach: after the standard lazyMaxMin check, if it returns Yes,
verify with isSuperTypeOf that the accepting type is actually a
supertype of the full intersection. This catches cases where
MixedType's accepts-everything behavior causes false acceptances
(e.g. array<int> falsely accepting array<mixed>&hasOffsetValue
or array<mixed>&callable intersections).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: 2 people

src/Type/IntersectionType.php

@@ -299,26 +299,18 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult
 
 	public function isAcceptedBy(Type $acceptingType, bool $strictTypes): AcceptsResult
 	{
-		$types = $this->types;
-		if ($this->isCallable()->yes() && $this->isArray()->yes()) {
-			$narrowedKeyType = $this->getIterableKeyType();
-			$narrowedValueType = $this->getIterableValueType();
-			$types = array_map(static function (Type $innerType) use ($narrowedKeyType, $narrowedValueType): Type {
-				if (!$innerType->isArray()->yes()) {
-					return $innerType;
-				}
-				if (!$innerType->getIterableValueType() instanceof MixedType) {
-					return $innerType;
-				}
-				return new ArrayType($narrowedKeyType, $narrowedValueType);
-			}, $types);
-		}
-
 		$result = AcceptsResult::lazyMaxMin(
-			$types,
+			$this->types,
 			static fn (Type $innerType) => $acceptingType->accepts($innerType, $strictTypes),
 		);
 
+		if ($result->yes()) {
+			$isSuperType = $acceptingType->isSuperTypeOf($this);
+			if ($isSuperType->no()) {
+				return $isSuperType->toAcceptsResult();
+			}
+		}
+
 		if ($this->isOversizedArray()->yes()) {
 			if (!$result->no()) {
 				return AcceptsResult::createYes();

tests/PHPStan/Rules/Methods/CallMethodsRuleTest.php

@@ -4055,6 +4055,10 @@ public function testBug14549(): void
 				'Parameter #1 $param of method Bug14549Bis\Foo::callConstantArrayObjectOrStringStringString() expects array{object|string, string, string}, array&callable(): mixed given.',
 				47,
 			],
+			[
+				'Parameter #1 $param of method Bug14549Bis\Foo::callArrayString() expects array<string>, array given.',
+				58,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Methods/data/bug-14549-bis.php

@@ -47,4 +47,17 @@ public function doCallWithCallableAndArray(array $task): void
 		$this->callConstantArrayObjectOrStringStringString($task);
 	}
 
+	/** @param array<string> $param */
+	public function callArrayString(array $param): void
+	{
+	}
+
+	public function doCallWithHasOffsetValue(array $arr): void
+	{
+		if (isset($arr[1]) && $arr[1] === 1) {
+			$this->callArrayString($arr);
+			$this->callArrayInt($arr);
+		}
+	}
+
 }