Change MethodVisibilityComparisonHelper::compare() to accept Node instead of optional line number

Address review feedback: replace optional `?int $line = null` parameter with
a required `Node $node` parameter, calling `$node->getStartLine()` inside the
helper. This simplifies callers and makes the API more explicit.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: phpstan-bot

src/Rules/Methods/ConsistentConstructorRule.php

@@ -48,7 +48,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		return array_merge(
 			$this->methodParameterComparisonHelper->compare($parentConstructor, $parentConstructor->getDeclaringClass(), $method, true),
-			$this->methodVisibilityComparisonHelper->compare($parentConstructor, $parentConstructor->getDeclaringClass(), $method, $node->getOriginalNode()->name->getStartLine()),
+			$this->methodVisibilityComparisonHelper->compare($parentConstructor, $parentConstructor->getDeclaringClass(), $method, $node->getOriginalNode()->name),
 		);
 	}
 

src/Rules/Methods/MethodVisibilityComparisonHelper.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Rules\Methods;
 
+use PhpParser\Node;
 use PHPStan\DependencyInjection\AutowiredService;
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\ExtendedMethodReflection;
@@ -15,14 +16,14 @@ final class MethodVisibilityComparisonHelper
 {
 
 	/** @return list<IdentifierRuleError> */
-	public function compare(ExtendedMethodReflection $prototype, ClassReflection $prototypeDeclaringClass, PhpMethodFromParserNodeReflection $method, ?int $line = null): array
+	public function compare(ExtendedMethodReflection $prototype, ClassReflection $prototypeDeclaringClass, PhpMethodFromParserNodeReflection $method, Node $node): array
 	{
 		/** @var list<IdentifierRuleError> $messages */
 		$messages = [];
 
 		if ($prototype->isPublic()) {
 			if (!$method->isPublic()) {
-				$errorBuilder = RuleErrorBuilder::message(sprintf(
+				$messages[] = RuleErrorBuilder::message(sprintf(
 					'%s method %s::%s() overriding public method %s::%s() should also be public.',
 					$method->isPrivate() ? 'Private' : 'Protected',
 					$method->getDeclaringClass()->getDisplayName(),
@@ -31,26 +32,22 @@ public function compare(ExtendedMethodReflection $prototype, ClassReflection $pr
 					$prototype->getName(),
 				))
 					->nonIgnorable()
-					->identifier('method.visibility');
-				if ($line !== null) {
-					$errorBuilder->line($line);
-				}
-				$messages[] = $errorBuilder->build();
+					->identifier('method.visibility')
+					->line($node->getStartLine())
+					->build();
 			}
 		} elseif ($method->isPrivate()) {
-			$errorBuilder = RuleErrorBuilder::message(sprintf(
+			$messages[] = RuleErrorBuilder::message(sprintf(
 				'Private method %s::%s() overriding protected method %s::%s() should be protected or public.',
 				$method->getDeclaringClass()->getDisplayName(),
 				$method->getName(),
 				$prototypeDeclaringClass->getDisplayName(true),
 				$prototype->getName(),
 			))
 				->nonIgnorable()
-				->identifier('method.visibility');
-			if ($line !== null) {
-				$errorBuilder->line($line);
-			}
-			$messages[] = $errorBuilder->build();
+				->identifier('method.visibility')
+				->line($node->getStartLine())
+				->build();
 		}
 
 		return $messages;

src/Rules/Methods/OverridingMethodRule.php

@@ -189,7 +189,7 @@ public function processNode(Node $node, Scope&NodeCallbackInvoker $scope): array
 		}
 
 		if ($checkVisibility) {
-			$messages = array_merge($messages, $this->methodVisibilityComparisonHelper->compare($prototype, $prototypeDeclaringClass, $method, $node->getOriginalNode()->name->getStartLine()));
+			$messages = array_merge($messages, $this->methodVisibilityComparisonHelper->compare($prototype, $prototypeDeclaringClass, $method, $node->getOriginalNode()->name));
 		}
 
 		$prototypeVariants = $prototype->getVariants();