Feedback

Author: VincentLanglet

src/dumpType.php

@@ -5,35 +5,38 @@
 /**
  * @phpstan-pure
  * @param mixed $value
+ * @param mixed $values
  * @return mixed
  *
  * @throws void
  */
-function dumpType(...$value) // phpcs:ignore Squiz.Functions.GlobalFunction.Found
+function dumpType($value, ...$values) // phpcs:ignore Squiz.Functions.GlobalFunction.Found
 {
 	return null;
 }
 
 /**
  * @phpstan-pure
  * @param mixed $value
+ * @param mixed $values
  * @return mixed
  *
  * @throws void
  */
-function dumpNativeType(...$value) // phpcs:ignore Squiz.Functions.GlobalFunction.Found
+function dumpNativeType($value, ...$values) // phpcs:ignore Squiz.Functions.GlobalFunction.Found
 {
 	return null;
 }
 
 /**
  * @phpstan-pure
  * @param mixed $value
+ * @param mixed $values
  * @return mixed
  *
  * @throws void
  */
-function dumpPhpDocType(...$value) // phpcs:ignore Squiz.Functions.GlobalFunction.Found
+function dumpPhpDocType($value, ...$values) // phpcs:ignore Squiz.Functions.GlobalFunction.Found
 {
 	return null;
 }

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

@@ -2679,6 +2679,24 @@ public function testBug8936(): void
 		$this->analyse([__DIR__ . '/data/bug-8936.php'], []);
 	}
 
+	public function testDumpFunctions(): void
+	{
+		$this->analyse([__DIR__ . '/data/dump-functions.php'], [
+			[
+				'Function PHPStan\dumpType invoked with 0 parameters, at least 1 required.',
+				13,
+			],
+			[
+				'Function PHPStan\dumpNativeType invoked with 0 parameters, at least 1 required.',
+				14,
+			],
+			[
+				'Function PHPStan\dumpPhpDocType invoked with 0 parameters, at least 1 required.',
+				15,
+			],
+		]);
+	}
+
 	public function testBug14012(): void
 	{
 		$this->checkExplicitMixed = true;

tests/PHPStan/Rules/Functions/data/dump-functions.php

@@ -0,0 +1,21 @@
+<?php
+
+namespace DumpFunctions;
+
+use function PHPStan\dumpType;
+use function PHPStan\dumpNativeType;
+use function PHPStan\dumpPhpdocType;
+
+class HelloWorld
+{
+	public function sayHello(): void
+	{
+		dumpType();
+		dumpNativeType();
+		dumpPhpdocType();
+
+		dumpType(1, 2, 3);
+		dumpNativeType(1, 2, 3);
+		dumpPhpdocType(1, 2, 3);
+	}
+}