Declare multiple apcu_ functions as impure (#5516)

Author: madmajestro

bin/functionMetadata_original.php

@@ -6,6 +6,20 @@
 	'acosh' => ['hasSideEffects' => false],
 	'addcslashes' => ['hasSideEffects' => false],
 	'addslashes' => ['hasSideEffects' => false],
+	'apcu_add' => ['hasSideEffects' => true],
+	'apcu_cache_info' => ['hasSideEffects' => true],
+	'apcu_cas' => ['hasSideEffects' => true],
+	'apcu_clear_cache' => ['hasSideEffects' => true],
+	'apcu_dec' => ['hasSideEffects' => true],
+	'apcu_delete' => ['hasSideEffects' => true],
+	'apcu_enabled' => ['hasSideEffects' => true],
+	'apcu_entry' => ['hasSideEffects' => true],
+	'apcu_exists' => ['hasSideEffects' => true],
+	'apcu_fetch' => ['hasSideEffects' => true],
+	'apcu_inc' => ['hasSideEffects' => true],
+	'apcu_key_info' => ['hasSideEffects' => true],
+	'apcu_sma_info' => ['hasSideEffects' => true],
+	'apcu_store' => ['hasSideEffects' => true],
 	'array_change_key_case' => ['hasSideEffects' => false],
 	'array_chunk' => ['hasSideEffects' => false],
 	'array_column' => ['hasSideEffects' => false],

resources/functionMetadata.php

@@ -712,6 +712,20 @@
 	'apache_get_version' => ['hasSideEffects' => false],
 	'apache_getenv' => ['hasSideEffects' => false],
 	'apache_request_headers' => ['hasSideEffects' => false],
+	'apcu_add' => ['hasSideEffects' => true],
+	'apcu_cache_info' => ['hasSideEffects' => true],
+	'apcu_cas' => ['hasSideEffects' => true],
+	'apcu_clear_cache' => ['hasSideEffects' => true],
+	'apcu_dec' => ['hasSideEffects' => true],
+	'apcu_delete' => ['hasSideEffects' => true],
+	'apcu_enabled' => ['hasSideEffects' => true],
+	'apcu_entry' => ['hasSideEffects' => true],
+	'apcu_exists' => ['hasSideEffects' => true],
+	'apcu_fetch' => ['hasSideEffects' => true],
+	'apcu_inc' => ['hasSideEffects' => true],
+	'apcu_key_info' => ['hasSideEffects' => true],
+	'apcu_sma_info' => ['hasSideEffects' => true],
+	'apcu_store' => ['hasSideEffects' => true],
 	'array_change_key_case' => ['hasSideEffects' => false],
 	'array_chunk' => ['hasSideEffects' => false],
 	'array_column' => ['hasSideEffects' => false],
@@ -1744,4 +1758,4 @@
 	'zlib_encode' => ['hasSideEffects' => false],
 	'zlib_get_coding_type' => ['hasSideEffects' => false],
 
-];
+];

tests/PHPStan/Rules/Comparison/StrictComparisonOfDifferentTypesRuleTest.php

@@ -1197,4 +1197,9 @@ public function testBug14446(): void
 		$this->analyse([__DIR__ . '/../../Analyser/data/bug-14446.php'], []);
 	}
 
+	public function testBug14473(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-14519.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Comparison/data/bug-14519.php

@@ -0,0 +1,19 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14519;
+
+$entry = apcu_fetch("key1");
+
+if ($entry === false) {
+	die();
+}
+
+// assume long-running task when $entry exists
+
+// re-fetch key "key1" again (it probably has been changed or deleted in the meantime by another process)
+$entry = apcu_fetch("key1");
+
+// phpstan complains here, but it shouldn't
+if ($entry === false) {
+	die();
+}