fix

Co-Authored-By: Vincent Langlet <VincentLanglet@users.noreply.github.com>

Author: staabm

src/Analyser/TypeSpecifier.php

@@ -1588,8 +1588,7 @@ private function getConditionalSpecifiedTypes(
 			(
 				$argumentExpr instanceof Node\Scalar
 				|| ($argumentExpr instanceof ConstFetch && in_array(strtolower($argumentExpr->name->toString()), ['true', 'false', 'null'], true))
-				&& ($ifType instanceof NeverType || $elseType instanceof NeverType)
-			)
+			) && ($ifType instanceof NeverType || $elseType instanceof NeverType)
 		) {
 			return null;
 		}

tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeFunctionCallRuleTest.php

@@ -74,6 +74,14 @@ public function testImpossibleCheckTypeFunctionCall(): void
 					'Call to function is_callable() with \'nonexistentFunction\' will always evaluate to false.',
 					87,
 				],
+				[
+					'Call to function is_numeric() with \'123\' will always evaluate to true.',
+					102,
+				],
+				[
+					'Call to function is_numeric() with \'blabla\' will always evaluate to false.',
+					105,
+				],
 				[
 					'Call to function is_numeric() with 123|float will always evaluate to true.',
 					118,
@@ -223,11 +231,19 @@ public function testImpossibleCheckTypeFunctionCall(): void
 					718,
 					'Because the type is coming from a PHPDoc, you can turn off this check by setting <fg=cyan>treatPhpDocTypesAsCertain: false</> in your <fg=cyan>%configurationFile%</>.',
 				],
+				[
+					'Call to function is_numeric() with \'123\' will always evaluate to true.',
+					718,
+				],
 				[
 					'Call to function assert() with false will always evaluate to false.',
 					719,
 					'Because the type is coming from a PHPDoc, you can turn off this check by setting <fg=cyan>treatPhpDocTypesAsCertain: false</> in your <fg=cyan>%configurationFile%</>.',
 				],
+				[
+					'Call to function is_numeric() with \'blabla\' will always evaluate to false.',
+					719,
+				],
 				[
 					'Call to function assert() with true will always evaluate to true.',
 					726,