No need to have generics in class constant-related messages

Author: ondrejmirtes

src/Rules/Constants/OverridingConstantRule.php

@@ -65,9 +65,9 @@ private function processSingleConstant(ClassReflection $classReflection, string
 		if ($prototype->isFinal()) {
 			$errors[] = RuleErrorBuilder::message(sprintf(
 				'Constant %s::%s overrides final constant %s::%s.',
-				$classReflection->getDisplayName(),
+				$classReflection->getDisplayName(false),
 				$constantReflection->getName(),
-				$prototype->getDeclaringClass()->getDisplayName(),
+				$prototype->getDeclaringClass()->getDisplayName(false),
 				$prototype->getName(),
 			))->identifier('classConstant.final')->nonIgnorable()->build();
 		}
@@ -77,18 +77,18 @@ private function processSingleConstant(ClassReflection $classReflection, string
 				$errors[] = RuleErrorBuilder::message(sprintf(
 					'%s constant %s::%s overriding public constant %s::%s should also be public.',
 					$constantReflection->isPrivate() ? 'Private' : 'Protected',
-					$constantReflection->getDeclaringClass()->getDisplayName(),
+					$constantReflection->getDeclaringClass()->getDisplayName(false),
 					$constantReflection->getName(),
-					$prototype->getDeclaringClass()->getDisplayName(),
+					$prototype->getDeclaringClass()->getDisplayName(false),
 					$prototype->getName(),
 				))->identifier('classConstant.visibility')->nonIgnorable()->build();
 			}
 		} elseif ($constantReflection->isPrivate()) {
 			$errors[] = RuleErrorBuilder::message(sprintf(
 				'Private constant %s::%s overriding protected constant %s::%s should be protected or public.',
-				$constantReflection->getDeclaringClass()->getDisplayName(),
+				$constantReflection->getDeclaringClass()->getDisplayName(false),
 				$constantReflection->getName(),
-				$prototype->getDeclaringClass()->getDisplayName(),
+				$prototype->getDeclaringClass()->getDisplayName(false),
 				$prototype->getName(),
 			))->identifier('classConstant.visibility')->nonIgnorable()->build();
 		}
@@ -105,19 +105,19 @@ private function processSingleConstant(ClassReflection $classReflection, string
 					$errors[] = RuleErrorBuilder::message(sprintf(
 						'Native type %s of constant %s::%s is not covariant with native type %s of constant %s::%s.',
 						$constantNativeType->describe(VerbosityLevel::typeOnly()),
-						$constantReflection->getDeclaringClass()->getDisplayName(),
+						$constantReflection->getDeclaringClass()->getDisplayName(false),
 						$constantReflection->getName(),
 						$prototypeNativeType->describe(VerbosityLevel::typeOnly()),
-						$prototype->getDeclaringClass()->getDisplayName(),
+						$prototype->getDeclaringClass()->getDisplayName(false),
 						$prototype->getName(),
 					))->identifier('classConstant.nativeType')->nonIgnorable()->build();
 				}
 			} else {
 				$errors[] = RuleErrorBuilder::message(sprintf(
 					'Constant %s::%s overriding constant %s::%s (%s) should also have native type %s.',
-					$constantReflection->getDeclaringClass()->getDisplayName(),
+					$constantReflection->getDeclaringClass()->getDisplayName(false),
 					$constantReflection->getName(),
-					$prototype->getDeclaringClass()->getDisplayName(),
+					$prototype->getDeclaringClass()->getDisplayName(false),
 					$prototype->getName(),
 					$prototypeNativeType->describe(VerbosityLevel::typeOnly()),
 					$prototypeNativeType->describe(VerbosityLevel::typeOnly()),
@@ -137,10 +137,10 @@ private function processSingleConstant(ClassReflection $classReflection, string
 			$errors[] = RuleErrorBuilder::message(sprintf(
 				'Type %s of constant %s::%s is not covariant with type %s of constant %s::%s.',
 				$constantReflection->getValueType()->describe(VerbosityLevel::value()),
-				$constantReflection->getDeclaringClass()->getDisplayName(),
+				$constantReflection->getDeclaringClass()->getDisplayName(false),
 				$constantReflection->getName(),
 				$prototype->getValueType()->describe(VerbosityLevel::value()),
-				$prototype->getDeclaringClass()->getDisplayName(),
+				$prototype->getDeclaringClass()->getDisplayName(false),
 				$prototype->getName(),
 			))->identifier('classConstant.type')->build();
 		}