Return IsSuperTypeOfResult from ExpressionTypeHolder::isSuperTypeOf() for consistency

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: phpstan-bot

src/Analyser/ExpressionTypeHolder.php

@@ -4,6 +4,7 @@
 
 use PhpParser\Node\Expr;
 use PHPStan\TrinaryLogic;
+use PHPStan\Type\IsSuperTypeOfResult;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeCombinator;
 
@@ -50,17 +51,21 @@ public function equals(self $other): bool
 		return $this->type === $other->type || $this->type->equals($other->type);
 	}
 
-	public function isSuperTypeOf(self $other): bool
+	public function isSuperTypeOf(self $other): IsSuperTypeOfResult
 	{
 		if ($this === $other) {
-			return true;
+			return IsSuperTypeOfResult::createYes();
 		}
 
 		if (!$this->certainty->equals($other->certainty)) {
-			return false;
+			return IsSuperTypeOfResult::createNo();
+		}
+
+		if ($this->type === $other->type) {
+			return IsSuperTypeOfResult::createYes();
 		}
 
-		return $this->type === $other->type || $this->type->isSuperTypeOf($other->type)->yes();
+		return $this->type->isSuperTypeOf($other->type);
 	}
 
 	public function and(self $other): self

src/Analyser/MutatingScope.php

@@ -3230,7 +3230,7 @@ public function filterBySpecifiedTypes(SpecifiedTypes $specifiedTypes): self
 						}
 						if (!$specifiedExpressions[$holderExprString]->equals($conditionalTypeHolder)) {
 							$allExact = false;
-							if (!$conditionalTypeHolder->isSuperTypeOf($specifiedExpressions[$holderExprString])) {
+							if (!$conditionalTypeHolder->isSuperTypeOf($specifiedExpressions[$holderExprString])->yes()) {
 								$allSuperType = false;
 								break;
 							}