Make getConstants() array keys optional when filter is non-constant

When getConstants() receives a filter argument that isn't a single
constant integer value, we can't determine which constants will be
included in the result. Mark all keys as optional in this case instead
of treating them as always-defined.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: phpstan-bot

src/Type/Php/ReflectionClassGetConstantsDynamicReturnTypeExtension.php

@@ -115,18 +115,21 @@ private function resolveGetConstant(MethodCall $methodCall, Scope $scope, array
 	private function resolveGetConstants(array $classReflections, ?Type $filterType): ?Type
 	{
 		$filter = null;
+		$filterIsUncertain = false;
 		if ($filterType !== null) {
 			$filterScalars = $filterType->getConstantScalarValues();
 			if (count($filterScalars) === 1 && is_int($filterScalars[0])) {
 				$filter = $filterScalars[0];
+			} else {
+				$filterIsUncertain = true;
 			}
 		}
 
 		$types = [];
 		foreach ($classReflections as $classReflection) {
 			$builder = ConstantArrayTypeBuilder::createEmpty();
 			foreach ($this->getClassConstants($classReflection, $filter) as [$name, $valueType]) {
-				$builder->setOffsetValueType(new ConstantStringType($name), $valueType);
+				$builder->setOffsetValueType(new ConstantStringType($name), $valueType, $filterIsUncertain);
 			}
 			$types[] = $builder->getArray();
 		}

tests/PHPStan/Analyser/nsrt/reflection-class-get-constants.php

@@ -186,3 +186,11 @@ function testGetConstantsWithFilter(ReflectionClass $ref): void
 	assertType('array{C: 3.14}', $ref->getConstants(\ReflectionClassConstant::IS_PROTECTED));
 	assertType('array{D: true}', $ref->getConstants(\ReflectionClassConstant::IS_PRIVATE));
 }
+
+/**
+ * @param ReflectionClass<Foo> $ref
+ */
+function testGetConstantsWithDynamicFilter(ReflectionClass $ref, int $filter): void
+{
+	assertType("array{A?: 1, B?: 'hello', C?: 3.14, D?: true}", $ref->getConstants($filter));
+}