Use catch type as assigned expression in VariableAssignNode for catch variables

The VariableAssignNode for catch variables was using the variable itself
as the assigned expression, which meant ParameterOutAssignedTypeRule
could not detect type mismatches when a catch variable overwrites a
by-ref parameter. Now uses TypeExpr wrapping the catch type so the
parameterByRef.type check works correctly.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: phpstan-bot

src/Analyser/NodeScopeResolver.php

@@ -1974,7 +1974,7 @@ public function processStmtNode(
 					}
 
 					$variableName = $catchNode->var->name;
-					$this->callNodeCallback($nodeCallback, new VariableAssignNode($catchNode->var, $catchNode->var), $scope, $storage);
+					$this->callNodeCallback($nodeCallback, new VariableAssignNode($catchNode->var, new TypeExpr($catchType)), $scope, $storage);
 				}
 
 				$catchScopeResult = $this->processStmtNodesInternal($catchNode, $catchNode->stmts, $catchScope->enterCatchType($catchType, $variableName), $storage, $nodeCallback, $context);

tests/PHPStan/Rules/Variables/ParameterOutAssignedTypeRuleTest.php

@@ -91,4 +91,19 @@ public function testBug14124b(): void
 		$this->analyse([__DIR__ . '/data/bug-14124b.php'], []);
 	}
 
+	public function testCatchVariable(): void
+	{
+		$this->analyse([__DIR__ . '/data/parameter-out-catch-variable.php'], [
+			[
+				'Parameter &$p @param-out type of function ParameterOutCatchVariable\foo() expects int, Exception given.',
+				11,
+			],
+			[
+				'Parameter &$p by-ref type of function ParameterOutCatchVariable\bar() expects int, Exception given.',
+				19,
+				'You can change the parameter out type with @param-out PHPDoc tag.',
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Variables/data/parameter-out-catch-variable.php

@@ -0,0 +1,22 @@
+<?php
+
+namespace ParameterOutCatchVariable;
+
+/**
+ * @param-out int $p
+ */
+function foo(&$p): void {
+	try {
+		throw new \Exception();
+	} catch (\Exception $p) {
+
+	}
+}
+
+function bar(int &$p): void {
+	try {
+		throw new \Exception();
+	} catch (\Exception $p) {
+
+	}
+}