Extract getMethodWithMostParameters() into cached private method

Replace all occurrences of $this->methods[0] with a call to the new
getMethodWithMostParameters() private method, which caches its result.
This addresses the review feedback to avoid duplicating the method
selection logic and to add caching.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: 2 people

src/Reflection/Type/IntersectionTypeMethodReflection.php

@@ -22,6 +22,8 @@
 final class IntersectionTypeMethodReflection implements ExtendedMethodReflection
 {
 
+	private ?ExtendedMethodReflection $methodWithMostParameters = null;
+
 	/**
 	 * @param ExtendedMethodReflection[] $methods
 	 */
@@ -31,7 +33,7 @@ public function __construct(private string $methodName, private array $methods)
 
 	public function getDeclaringClass(): ClassReflection
 	{
-		return $this->methods[0]->getDeclaringClass();
+		return $this->getMethodWithMostParameters()->getDeclaringClass();
 	}
 
 	public function isStatic(): bool
@@ -95,19 +97,6 @@ public function getVariants(): array
 		$returnType = TypeCombinator::intersect(...$returnTypes);
 		$phpDocReturnType = TypeCombinator::intersect(...$phpDocReturnTypes);
 		$nativeReturnType = TypeCombinator::intersect(...$nativeReturnTypes);
-		$methodWithMostParameters = $this->methods[0];
-		$maxParameters = 0;
-		foreach ($this->methods as $method) {
-			foreach ($method->getVariants() as $variant) {
-				if (count($variant->getParameters()) <= $maxParameters) {
-					continue;
-				}
-
-				$maxParameters = count($variant->getParameters());
-				$methodWithMostParameters = $method;
-			}
-		}
-
 		return array_map(static fn (ExtendedParametersAcceptor $acceptor): ExtendedParametersAcceptor => new ExtendedFunctionVariant(
 			$acceptor->getTemplateTypeMap(),
 			$acceptor->getResolvedTemplateTypeMap(),
@@ -117,7 +106,7 @@ public function getVariants(): array
 			$phpDocReturnType,
 			$nativeReturnType,
 			$acceptor->getCallSiteVarianceMap(),
-		), $methodWithMostParameters->getVariants());
+		), $this->getMethodWithMostParameters()->getVariants());
 	}
 
 	public function getOnlyVariant(): ExtendedParametersAcceptor
@@ -250,7 +239,7 @@ public function isAbstract(): TrinaryLogic
 
 	public function getAttributes(): array
 	{
-		return $this->methods[0]->getAttributes();
+		return $this->getMethodWithMostParameters()->getAttributes();
 	}
 
 	public function mustUseReturnValue(): TrinaryLogic
@@ -260,7 +249,31 @@ public function mustUseReturnValue(): TrinaryLogic
 
 	public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock
 	{
-		return $this->methods[0]->getResolvedPhpDoc();
+		return $this->getMethodWithMostParameters()->getResolvedPhpDoc();
+	}
+
+	private function getMethodWithMostParameters(): ExtendedMethodReflection
+	{
+		if ($this->methodWithMostParameters !== null) {
+			return $this->methodWithMostParameters;
+		}
+
+		$methodWithMostParameters = $this->methods[0];
+		$maxParameters = 0;
+		foreach ($this->methods as $method) {
+			foreach ($method->getVariants() as $variant) {
+				if (count($variant->getParameters()) <= $maxParameters) {
+					continue;
+				}
+
+				$maxParameters = count($variant->getParameters());
+				$methodWithMostParameters = $method;
+			}
+		}
+
+		$this->methodWithMostParameters = $methodWithMostParameters;
+
+		return $methodWithMostParameters;
 	}
 
 }