Rewrite tests to exercise actual guarded code paths

Most tests were simple `$fn = someFunc(...); assertType(...)` patterns
that never triggered the assertion because standalone assignments only
exercise the TypeSpecifier assign patterns (array_key_first,
array_key_last, array_rand, count-1). Functions like strlen, count,
gettype, trim etc. need their first-class callables inside if-conditions
to exercise the comparison, identical, and string-equality guards.

Each test now uses the specific expression pattern that would crash
without the corresponding isFirstClassCallable() guard:
- Comparisons: `if (count(...) < 1)`, `if (0 < strlen(...))`
- Identicals: `if (count(...) === 0)`, `if (strlen(...) === 0)`
- Null checks: `if (array_key_first(...) !== null)`
- String equality: `if (gettype(...) === 'string')`, `if (trim(...) !== '')`
- Conditions: `if ($key = array_search(...))`
- Foreach: `foreach (array_keys(...) as $key)`
- For loops: `for ($i = 0; $i < count(...); $i++)`

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: phpstan-bot

tests/PHPStan/Analyser/nsrt/bug-14550.php

@@ -6,121 +6,155 @@
 
 use function PHPStan\Testing\assertType;
 
-/**
- * @param list<string> $list
- */
-function crashArrayKeyFirst(array $list): void
+// Standalone assignments trigger TypeSpecifier via NodeScopeResolver null-context call
+function testArrayKeyFirstAssign(): void
 {
 	$fn = array_key_first(...);
 	assertType('Closure(array): (int|string|null)', $fn);
 }
 
-/**
- * @param list<string> $list
- */
-function crashArrayKeyLast(array $list): void
+function testArrayKeyLastAssign(): void
 {
 	$fn = array_key_last(...);
 	assertType('Closure(array): (int|string|null)', $fn);
 }
 
-/**
- * @param list<string> $list
- */
-function crashArrayRand(array $list): void
+function testArrayRandAssign(): void
 {
 	$fn = array_rand(...);
 	assertType('(Closure(non-empty-array): (int|string))|(Closure(non-empty-array, int<1, max>): (array<int, int|string>|int|string))', $fn);
 }
 
-/**
- * @param list<string> $list
- */
-function crashArraySearch(array $list, string $s): void
+function testCountMinusOneAssign(): void
 {
-	$fn = array_search(...);
-	assertType('Closure(mixed, array, bool=): (int|string|false)', $fn);
+	$idx = count(...) - 1;
+	assertType('Closure(array|Countable, 0|1=): int<0, max>', count(...));
 }
 
-function testStrlen(): void
+// array_search guard needs true context, so it must be in a condition
+function testArraySearchInCondition(): void
 {
-	$fn = strlen(...);
-	assertType('Closure(string): int<0, max>', $fn);
+	if ($key = array_search(...)) {
+		assertType('Closure(mixed, array, bool=): (int|string|false)', $key);
+	}
 }
 
-function testMbStrlen(): void
+// Comparison guards in TypeSpecifier (Smaller/SmallerOrEqual)
+function testCountInComparisons(): void
 {
-	$fn = mb_strlen(...);
-	assertType('Closure(string, string|null=): int<0, max>', $fn);
+	if (count(...) < 1) {}
+	if (0 < count(...)) {}
+	assertType('Closure(array|Countable, 0|1=): int<0, max>', count(...));
 }
 
-function testCount(): void
+function testSizeofInComparisons(): void
 {
-	$fn = count(...);
-	assertType('Closure(array|Countable, 0|1=): int<0, max>', $fn);
+	if (sizeof(...) < 1) {}
+	if (0 < sizeof(...)) {}
+	assertType('Closure(array|Countable, int=): int', sizeof(...));
 }
 
-function testSizeof(): void
+function testCountMinusOneInComparison(): void
 {
-	$fn = sizeof(...);
-	assertType('Closure(array|Countable, int=): int', $fn);
+	$i = 0;
+	if ($i < count(...) - 1) {}
+	assertType('Closure(array|Countable, 0|1=): int<0, max>', count(...));
 }
 
-function testPregMatch(): void
+function testStrlenInComparisons(): void
 {
-	$fn = preg_match(...);
-	assertType('Closure(string, string, array<string>|null=, TFlags=, int=): (0|1|false)', $fn);
+	if (strlen(...) < 1) {}
+	if (0 < strlen(...)) {}
+	assertType('Closure(string): int<0, max>', strlen(...));
 }
 
-function testGettype(): void
+function testMbStrlenInComparisons(): void
 {
-	$fn = gettype(...);
-	assertType('Closure(mixed): string', $fn);
+	if (mb_strlen(...) < 1) {}
+	if (0 < mb_strlen(...)) {}
+	assertType('Closure(string, string|null=): int<0, max>', mb_strlen(...));
 }
 
-function testGetClass(): void
+function testPregMatchInComparisons(): void
 {
-	$fn = get_class(...);
-	assertType('Closure(object=): class-string', $fn);
+	if (preg_match(...) < 1) {}
+	if (0 < preg_match(...)) {}
+	assertType('Closure(string, string, array<string>|null=, TFlags=, int=): (0|1|false)', preg_match(...));
 }
 
-function testGetDebugType(): void
+// Identical/NotIdentical guards in resolveNormalizedIdentical
+function testCountIdentical(): void
 {
-	$fn = get_debug_type(...);
-	assertType('Closure(mixed): string', $fn);
+	if (count(...) === 0) {}
+	assertType('Closure(array|Countable, 0|1=): int<0, max>', count(...));
 }
 
-function testGetParentClass(): void
+function testStrlenIdentical(): void
 {
-	$fn = get_parent_class(...);
-	assertType('Closure(object|string=): (class-string|false)', $fn);
+	if (strlen(...) === 0) {}
+	if (mb_strlen(...) === 0) {}
+	assertType('Closure(string): int<0, max>', strlen(...));
 }
 
-function testTrim(): void
+function testArrayKeyFirstNullComparison(): void
 {
-	$fn = trim(...);
-	assertType('Closure(string, string=): string', $fn);
+	if (array_key_first(...) !== null) {}
+	if (array_key_last(...) !== null) {}
+	assertType('Closure(array): (int|string|null)', array_key_first(...));
 }
 
-function testLtrim(): void
+function testGetClassIdentical(): void
 {
-	$fn = ltrim(...);
-	assertType('Closure(string, string=): string', $fn);
+	if (get_class(...) === 'stdClass') {}
+	if (get_debug_type(...) === 'string') {}
+	assertType('Closure(object=): class-string', get_class(...));
 }
 
-function testRtrim(): void
+function testStringFuncIdentical(): void
 {
-	$fn = rtrim(...);
-	assertType('Closure(string, string=): string', $fn);
+	if (strtolower(...) === 'test') {}
+	assertType('Closure(string): lowercase-string', strtolower(...));
 }
 
-/**
- * @param list<string> $list
- */
-function testArrayKeysInForeach(array $list): void
+// String equality guards in specifyTypesForConstantStringBinaryExpression
+function testGettypeEquality(): void
 {
-	foreach (array_keys(...) as $key) {
-	}
-	$fn = array_keys(...);
-	assertType('Closure(array, mixed=, bool=): list<int|string>', $fn);
+	if (gettype(...) === 'string') {}
+	if (gettype(...) == 'string') {}
+	assertType('Closure(mixed): string', gettype(...));
+}
+
+function testGetClassEquality(): void
+{
+	if (get_class(...) == 'stdClass') {}
+	if (get_debug_type(...) == 'string') {}
+	assertType('Closure(object=): class-string', get_class(...));
+}
+
+function testGetParentClassEquality(): void
+{
+	if (get_parent_class(...) === 'stdClass') {}
+	assertType('Closure(object|string=): (class-string|false)', get_parent_class(...));
+}
+
+function testTrimEquality(): void
+{
+	if (trim(...) !== '') {}
+	if (ltrim(...) !== '') {}
+	if (rtrim(...) !== '') {}
+	assertType('Closure(string, string=): string', trim(...));
+}
+
+// NodeScopeResolver guards
+function testArrayKeysInForeach(): void
+{
+	foreach (array_keys(...) as $key) {}
+	assertType('Closure(array, mixed=, bool=): list<int|string>', array_keys(...));
+}
+
+function testCountInForLoop(): void
+{
+	for ($i = 0; $i < count(...); $i++) {}
+	for ($i = 0; count(...) > $i; $i++) {}
+	assertType('Closure(array|Countable, 0|1=): int<0, max>', count(...));
 }