Fix do-while(true) false positive when loop body has explicit throw points

- DoWhileLoopConstantConditionRule now considers explicit throw points as
  valid loop exit mechanisms, suppressing the "always true" warning
- Added throw points to DoWhileLoopConditionNode alongside exit points
- Updated NodeScopeResolver to pass throw points when creating the node
- New regression test in tests/PHPStan/Rules/Comparison/data/bug-5865.php

Closes phpstan/phpstan#5865

Author: github-actions[bot]

src/Analyser/NodeScopeResolver.php

@@ -1607,7 +1607,8 @@ private function processStmtNode(
 				$alwaysIterates = $condBooleanType->isTrue()->yes();
 			}
 
-			$this->callNodeCallback($nodeCallback, new DoWhileLoopConditionNode($stmt->cond, $bodyScopeResult->toPublic()->getExitPoints()), $bodyScope, $storage);
+			$publicResult = $bodyScopeResult->toPublic();
+			$this->callNodeCallback($nodeCallback, new DoWhileLoopConditionNode($stmt->cond, $publicResult->getExitPoints(), $publicResult->getThrowPoints()), $bodyScope, $storage);
 
 			if ($alwaysIterates) {
 				$alwaysTerminating = count($bodyScopeResult->getExitPointsByType(Break_::class)) === 0;

src/Node/DoWhileLoopConditionNode.php

@@ -6,14 +6,16 @@
 use PhpParser\Node\Expr;
 use PhpParser\NodeAbstract;
 use PHPStan\Analyser\StatementExitPoint;
+use PHPStan\Analyser\ThrowPoint;
 
 final class DoWhileLoopConditionNode extends NodeAbstract implements VirtualNode
 {
 
 	/**
 	 * @param StatementExitPoint[] $exitPoints
+	 * @param ThrowPoint[] $throwPoints
 	 */
-	public function __construct(private Expr $cond, private array $exitPoints)
+	public function __construct(private Expr $cond, private array $exitPoints, private array $throwPoints)
 	{
 		parent::__construct($cond->getAttributes());
 	}
@@ -31,6 +33,14 @@ public function getExitPoints(): array
 		return $this->exitPoints;
 	}
 
+	/**
+	 * @return ThrowPoint[]
+	 */
+	public function getThrowPoints(): array
+	{
+		return $this->throwPoints;
+	}
+
 	#[Override]
 	public function getType(): string
 	{

src/Rules/Comparison/DoWhileLoopConstantConditionRule.php

@@ -54,6 +54,11 @@ public function processNode(Node $node, Scope $scope): array
 						return [];
 					}
 				}
+				foreach ($node->getThrowPoints() as $throwPoint) {
+					if ($throwPoint->isExplicit()) {
+						return [];
+					}
+				}
 			} else {
 				foreach ($node->getExitPoints() as $exitPoint) {
 					$statement = $exitPoint->getStatement();

tests/PHPStan/Rules/Comparison/DoWhileLoopConstantConditionRuleTest.php

@@ -28,6 +28,11 @@ protected function getRule(): Rule
 		);
 	}
 
+	public function testBug5865(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-5865.php'], []);
+	}
+
 	public function testRule(): void
 	{
 		$this->analyse([__DIR__ . '/data/do-while-loop.php'], [

tests/PHPStan/Rules/Comparison/data/bug-5865.php

@@ -0,0 +1,25 @@
+<?php declare(strict_types = 1);
+
+namespace Bug5865;
+
+class HelloWorld
+{
+	public function sayHello(): void
+	{
+		try {
+			do {
+				$this->foo();
+			} while (true);
+		} catch (\RuntimeException $e) {
+			// ok
+		}
+	}
+
+	/**
+	 * @throws \RuntimeException
+	 */
+	public function foo(): void
+	{
+		throw new \RuntimeException();
+	}
+}