Remove comments and use @param mixed for PHP 7.4 compatibility

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: 2 people

src/Analyser/MutatingScope.php

@@ -3780,18 +3780,6 @@ private function createConditionalExpressions(
 				) {
 					continue;
 				}
-				// Skip non-Variable expressions absent from the other branch when
-				// the guard overlaps with the other branch's guard type.
-				// Non-Variable expressions (array dim fetches, property fetches)
-				// are always queryable, so absence from a branch means "not
-				// narrowed", not "doesn't exist". Creating a conditional
-				// expression would incorrectly narrow the type when the guard
-				// fires from the branch that never referenced the expression.
-				// Variables are exempt: their absence means genuinely "not
-				// defined", and conditional expressions for newly-defined
-				// variables are needed for variable certainty tracking (e.g.
-				// bug-14411-regression). Pre-defined variables (present in both
-				// branches) are handled by the check above.
 				if (
 					!array_key_exists($exprString, $theirExpressionTypes)
 					&& !$holder->getExpr() instanceof Variable

tests/PHPStan/Analyser/nsrt/bug-14469.php

@@ -18,8 +18,11 @@ function t(array $R, bool $var1, object $user): void {
 	}
 }
 
-/** Variable equivalent: pre-defined variable stays mixed inside if ($aa) */
-function variableEquivalent(mixed $input, bool $var1, object $user): void {
+/**
+ * Variable equivalent: pre-defined variable stays mixed inside if ($aa)
+ * @param mixed $input
+ */
+function variableEquivalent($input, bool $var1, object $user): void {
 	$aa = null;
 	$bb = $input;
 

tests/PHPStan/Rules/Comparison/data/bug-14469.php

@@ -73,13 +73,9 @@ function multipleElseif(array $R, bool $var1, bool $var2, object $user): void {
 }
 
 /**
- * Variable equivalent: pre-defined variable used in elseif condition.
- * Same pattern as the array dim fetch case but $bb is a Variable defined
- * before the if/elseif, so it's present in both branches' expression types.
- * The existing guard-overlap check (lines that test array_key_exists($exprString,
- * $theirExpressionTypes)) handles this case correctly.
+ * @param mixed $input
  */
-function variableEquivalent(bool $var1, object $user, mixed $input): void {
+function variableEquivalent(bool $var1, object $user, $input): void {
 	$aa = null;
 	$bb = $input;